libsodium 1.0.9

[woobs]

No description provided.

[apjanke]

@BrewTestBot test this please

[apjanke]

brew test fastd failed on Mavericks. Otherwise looks okay.

failed: brew test --verbose fastd

Stacktrace

        Testing fastd
==> Using the sandbox
/usr/bin/sandbox-exec -f /tmp/homebrew20160403-45567-1j6fppn-0.sb /Users/brewadmin/Homebrew/Cellar/ruby187/1.8.7-p374_1/bin/ruby -W0 -I /usr/local/Library/Homebrew -- /usr/local/Library/Homebrew/test.rb /usr/local/Library/Taps/homebrew/homebrew-core/Formula/fastd.rb --verbose
==> /usr/local/Cellar/fastd/17/bin/fastd
Error: fastd: failed
Failed executing: /usr/local/Cellar/fastd/17/bin/fastd 
/usr/local/Library/Homebrew/formula.rb:1481:in `system'
/usr/local/Library/Homebrew/formula.rb:1418:in `open'
/usr/local/Library/Homebrew/formula.rb:1418:in `system'
/usr/local/Library/Taps/homebrew/homebrew-core/Formula/fastd.rb:36:in `test'
/usr/local/Library/Homebrew/formula.rb:1327:in `run_test'
/usr/local/Library/Homebrew/extend/fileutils.rb:37:in `mktemp'
/usr/local/Library/Homebrew/formula.rb:1323:in `run_test'
/usr/local/Library/Homebrew/test.rb:28
/Users/brewadmin/Homebrew/Cellar/ruby187/1.8.7-p374_1/lib/ruby/1.8/timeout.rb:67:in `timeout'
/usr/local/Library/Homebrew/test.rb:27  

This doesn't look like a regression, but maybe we can fix it as part of this PR; I get a similar brew test fastd failure locally on 10.9.5 with the current libsodium 1.0.8. It just segfaults.

$ fastd
[1]    30103 segmentation fault  fastd
[✘ /usr/local/Library/Taps/homebrew/homebrew-dupes on ⇄ master]
$ fastd --help
[1]    30111 segmentation fault  fastd --help

This might be expected behavior, since I didn't install the kexts provided by tuntap.

fastd is not tested on 10.10 or 10.11 by the test bot. Maybe because it only has a bottle for Mavericks currently?

[apjanke]

Ah, yeah: only dependents that have tests defined and are bottled are considered testable.

The fastd fix is nontrivial; I put a bug report in as Homebrew/legacy-homebrew#50652 and we can deal with it later. Merging this now since it's not a regression.

[apjanke]

Merged. Thank you for your contribution to Homebrew!

[apjanke]

The fastd test is fixed in #23, so shouldn't experience this breakage on next libsodium update.