diff --git a/core/config/default-config.js b/core/config/default-config.js index b1893d379b70..96a4be25e672 100644 --- a/core/config/default-config.js +++ b/core/config/default-config.js @@ -517,7 +517,6 @@ const defaultConfig = { {id: 'non-composited-animations', weight: 0}, {id: 'unsized-images', weight: 0}, {id: 'viewport', weight: 0}, - {id: 'no-unload-listeners', weight: 0}, {id: 'uses-responsive-images-snapshot', weight: 0}, {id: 'work-during-interaction', weight: 0}, {id: 'bf-cache', weight: 0}, @@ -623,6 +622,7 @@ const defaultConfig = { {id: 'doctype', weight: 1, group: 'best-practices-browser-compat'}, {id: 'charset', weight: 1, group: 'best-practices-browser-compat'}, // General Group + {id: 'no-unload-listeners', weight: 1, group: 'best-practices-general'}, {id: 'js-libraries', weight: 0, group: 'best-practices-general'}, {id: 'deprecations', weight: 1, group: 'best-practices-general'}, {id: 'errors-in-console', weight: 1, group: 'best-practices-general'}, diff --git a/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json b/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json index 08cfeaa10906..b0da751a8819 100644 --- a/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json +++ b/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json @@ -3998,10 +3998,6 @@ "id": "viewport", "weight": 0 }, - { - "id": "no-unload-listeners", - "weight": 0 - }, { "id": "bf-cache", "weight": 0 @@ -4396,6 +4392,11 @@ "weight": 1, "group": "best-practices-browser-compat" }, + { + "id": "no-unload-listeners", + "weight": 1, + "group": "best-practices-general" + }, { "id": "js-libraries", "weight": 0, @@ -9338,10 +9339,6 @@ "id": "unsized-images", "weight": 0 }, - { - "id": "no-unload-listeners", - "weight": 0 - }, { "id": "work-during-interaction", "weight": 0 @@ -9417,6 +9414,11 @@ "weight": 0, "group": "best-practices-ux" }, + { + "id": "no-unload-listeners", + "weight": 1, + "group": "best-practices-general" + }, { "id": "deprecations", "weight": 1, @@ -9439,7 +9441,7 @@ } ], "id": "best-practices", - "score": 0.83 + "score": 0.86 } }, "categoryGroups": { @@ -18210,10 +18212,6 @@ "id": "viewport", "weight": 0 }, - { - "id": "no-unload-listeners", - "weight": 0 - }, { "id": "bf-cache", "weight": 0 @@ -18608,6 +18606,11 @@ "weight": 1, "group": "best-practices-browser-compat" }, + { + "id": "no-unload-listeners", + "weight": 1, + "group": "best-practices-general" + }, { "id": "js-libraries", "weight": 0, diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json index 541b640bcdd5..857f87c4b221 100644 --- a/core/test/results/sample_v2.json +++ b/core/test/results/sample_v2.json @@ -6291,10 +6291,6 @@ "id": "viewport", "weight": 0 }, - { - "id": "no-unload-listeners", - "weight": 0 - }, { "id": "bf-cache", "weight": 0 @@ -6689,6 +6685,11 @@ "weight": 1, "group": "best-practices-browser-compat" }, + { + "id": "no-unload-listeners", + "weight": 1, + "group": "best-practices-general" + }, { "id": "js-libraries", "weight": 0, @@ -6716,7 +6717,7 @@ } ], "id": "best-practices", - "score": 0.27 + "score": 0.25 }, "seo": { "title": "SEO", diff --git a/report/test/generator/report-generator-test.js b/report/test/generator/report-generator-test.js index e8416dc16a95..b6379101349d 100644 --- a/report/test/generator/report-generator-test.js +++ b/report/test/generator/report-generator-test.js @@ -108,7 +108,7 @@ describe('ReportGenerator', () => { category,score \\"performance\\",\\"0.26\\" \\"accessibility\\",\\"0.77\\" -\\"best-practices\\",\\"0.27\\" +\\"best-practices\\",\\"0.25\\" \\"seo\\",\\"0.67\\" \\"pwa\\",\\"0.33\\"