diff --git a/core/scripts/lantern/constants.js b/core/scripts/lantern/constants.js index cbc6d5acbadb..dcfa9acbd22c 100644 --- a/core/scripts/lantern/constants.js +++ b/core/scripts/lantern/constants.js @@ -48,9 +48,6 @@ import {LH_ROOT} from '../../../root.js'; * @property {number} [timeToConsistentlyInteractive] * @property {number} [speedIndex] * @property {number} [largestContentfulPaint] - * @property {number} [timeToFirstByte] - * @property {number} [lcpLoadStart] - * @property {number} [lcpLoadEnd] */ /** @@ -70,9 +67,6 @@ import {LH_ROOT} from '../../../root.js'; * @property {number} roughEstimateOfSI * @property {number} roughEstimateOfTTI * @property {number} roughEstimateOfLCP - * @property {number} roughEstimateOfTTFB - * @property {number} roughEstimateOfLCPLoadStart - * @property {number} roughEstimateOfLCPLoadEnd */ /** @type {Array} */ @@ -202,9 +196,6 @@ export default { roughEstimateOfSI: evaluate('speedIndex', 'roughEstimateOfSI'), roughEstimateOfTTI: evaluate('timeToConsistentlyInteractive', 'roughEstimateOfTTI'), roughEstimateOfLCP: evaluate('largestContentfulPaint', 'roughEstimateOfLCP'), - roughEstimateOfTTFB: evaluate('timeToFirstByte', 'roughEstimateOfTTFB'), - roughEstimateOfLCPLoadStart: evaluate('lcpLoadStart', 'roughEstimateOfLCPLoadStart'), - roughEstimateOfLCPLoadEnd: evaluate('lcpLoadEnd', 'roughEstimateOfLCPLoadEnd'), }; }, }; diff --git a/core/scripts/lantern/print-correlations.js b/core/scripts/lantern/print-correlations.js index caa7bb7d346f..5c16b195551b 100755 --- a/core/scripts/lantern/print-correlations.js +++ b/core/scripts/lantern/print-correlations.js @@ -100,7 +100,7 @@ function evaluateAndPrintAccuracy(metric, lanternMetric) { const baselineOptions = {alwaysGray: !lanternMetric.includes('roughEstimate')}; const strings = [ - lanternMetric.padEnd(30), + lanternMetric.padEnd(25), `${toPercentString(actualAccuracy.p50)} ${toBaselineDiffString( actualAccuracy.p50, baselineAccuracy.p50, @@ -216,7 +216,7 @@ function findAndPrintFixesRegressions() { console.log( chalk.bold( - 'Metric'.padEnd(30), + 'Metric'.padEnd(25), 'p50 (% Error)'.padEnd(20), 'p90 (% Error)'.padEnd(20), 'p95 (% Error)'.padEnd(20) @@ -243,10 +243,6 @@ evaluateAndPrintAccuracy('largestContentfulPaint', 'optimisticLCP'); evaluateAndPrintAccuracy('largestContentfulPaint', 'pessimisticLCP'); evaluateAndPrintAccuracy('largestContentfulPaint', 'roughEstimateOfLCP'); -evaluateAndPrintAccuracy('timeToFirstByte', 'roughEstimateOfTTFB'); -evaluateAndPrintAccuracy('lcpLoadStart', 'roughEstimateOfLCPLoadStart'); -evaluateAndPrintAccuracy('lcpLoadEnd', 'roughEstimateOfLCPLoadEnd'); - const estimates = allEvaluations.filter(entry => entry.lanternMetric.includes('roughEstimate')); const baselineEstimates = baselineEvaluations.filter(entry => entry.lanternMetric.includes('roughEstimate') diff --git a/core/scripts/lantern/run-on-all-assets.js b/core/scripts/lantern/run-on-all-assets.js index b117246ba8d4..4752bfc182f2 100755 --- a/core/scripts/lantern/run-on-all-assets.js +++ b/core/scripts/lantern/run-on-all-assets.js @@ -16,9 +16,6 @@ * @property {number|undefined} timeToConsistentlyInteractive * @property {number|undefined} speedIndex * @property {number|undefined} largestContentfulPaint - * @property {number|undefined} timeToFirstByte - * @property {number|undefined} lcpLoadStart - * @property {number|undefined} lcpLoadEnd */ /** @typedef {{url:string, unthrottled: GoldenUnthrottled, wpt3g: Wpt3gUnthrottled}} GoldenSite */ /** @typedef {{sites: GoldenSite[]}} Golden */ diff --git a/core/test/fixtures/lantern-baseline-accuracy.json b/core/test/fixtures/lantern-baseline-accuracy.json index 04fe0c7750ce..e76b3e2ce665 100644 --- a/core/test/fixtures/lantern-baseline-accuracy.json +++ b/core/test/fixtures/lantern-baseline-accuracy.json @@ -23,8 +23,5 @@ "p50": 0.20407433881343817, "p90": 0.6299877796078848, "p95": 0.8768898488120951 - }, - "roughEstimateOfTTFB": {}, - "roughEstimateOfLCPLoadStart": {}, - "roughEstimateOfLCPLoadEnd": {} + } }