Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GitVersion behaves different if it is used the first time where the fallback version strategy applies #3437

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Mar 12, 2023

Fix for #3436

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…nged in NextVersionCalculator::FindVersion and removing the FallbackVersionStrategy and move the logic to the NextVersionCalculator::GetNextVersions.
@HHobeck HHobeck force-pushed the feature/3436_GitVersion_behaves_different_if_it_is_used_the_first_time branch 4 times, most recently from 794ba6a to 1a5f524 Compare March 12, 2023 14:25
@HHobeck HHobeck force-pushed the feature/3436_GitVersion_behaves_different_if_it_is_used_the_first_time branch from 1a5f524 to 81ad112 Compare March 12, 2023 14:53
@arturcic arturcic merged commit bbf28be into GitTools:main Mar 12, 2023
@arturcic arturcic deleted the feature/3436_GitVersion_behaves_different_if_it_is_used_the_first_time branch March 12, 2023 23:48
@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2023

Thank you @HHobeck for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants