Add HEAD support for 5.x version, without introduction of new configuration properties. #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
requested changes
Jan 13, 2023
There was a problem hiding this comment.
Wow, I'm surprised this was possible to do in a backwards-compatible way. This has been the single most recurring issue since I started contributing to GitVersion. Fantastic work!
dotnet format fails, though. Can you please commit after running the following?
dotnet format ./src/ --exclude **/AddFormats/
asbjornu
reviewed
Jan 13, 2023
|
Thank you @U7nk for your contribution! |
This was referenced Jan 20, 2023
Closed
This was referenced Jan 20, 2023
Closed
arturcic
pushed a commit
that referenced
this pull request
Jan 20, 2023
Merge pull request #3338 from U7nk/HEAD_support_for_5.x Add HEAD support for 5.x version, without introduction of new configuration properties.
|
🎉 This issue has been resolved in version 5.12.0 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adaptation of #3241 to 5.x version without introduction of new configuration properties.
I would really like to see this behavior in 5.x version.
In our company we have sub repository in every project, and we struggle every time with the error.
Related Issue
#3233
How Has This Been Tested?
GivenARemoteGitRepositoryWhenCheckingOutDetachedHeadUsingExistingImplementationHandleDetachedBranch.Checklist: