Use the environment variable GIT_BRANCH as the current branch everywhere
#3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't just use the environment variable GIT_BRANCH in GitPreparer to find the current branch; allow GIT_BRANCH to specify which branch is being built in the GitVersionContext as well, so it can be used throughout the codebase. Fixes GitToolsGH-2900.
|
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi! Would this affect GitHub Action? I've been wanting to avoid using the PR version format for builds made from PR's, but since this build agent uses only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the environment variable
GIT_BRANCHis used to override which branch theGitPrepareruses for its logic. This PR expands that usage to the entire codebase by moving the logic fromGitPreparertoGitVersionContextFactory.I will add documentation for this when time allows.
Related Issue
Fixes #2900.
Motivation and Context
It's unintuitive that
GIT_BRANCHcan be used to override the branch name only for normalization and not for version calculation.How Has This Been Tested?
I added a test and refactored the plumbing a bit so it's easier to set environment variables inside a test.
Checklist: