Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dynamic tag evaluation #2416

Closed
wants to merge 11 commits into from

Conversation

DocZoid
Copy link

@DocZoid DocZoid commented Oct 5, 2020

Change tag evaluation (test only)

Description

added test for #2340 scenario 1, branch created on tagged commit should not consider the tag if it does not match to the current branch config

Related Issue

#2340

Motivation and Context

There are two scenarios where the tag should not be used to evaluate the version:

When I build a snapshot from the develop branch, tag the branch with the created version (e.g. 0.1.2-snapshot.2), and then branch this commit to a new release (release/0.1.2)
When I build a release candidate from a release branch, tag the release branch with the new created version (e.g. 0.1.2-rc.1), and then make a fast-forward merge to master, essentially having master point to that tagged commit

How Has This Been Tested?

This PR does not contain any fix yet, only a test to show the intended behavior.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Yannick Hein and others added 6 commits July 24, 2020 13:54
…mit should not consider the tag if it does not match to the current branch config
…mit should not consider the tag if it does not match to the current branch config
…mit should not consider the tag if it does not match to the current branch config
… commit, the tag should not be considered if it does not match to the current branch config
@asbjornu
Copy link
Member

Please have a look at the failing dotnet format. Also, this feels very similar to #2413, no?

Base automatically changed from master to main January 31, 2021 12:46
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 2, 2021
@stale stale bot closed this Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants