Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should accept Uint8Array as Array / data or bytes type #1553

Closed
1 of 3 tasks
arboleya opened this issue Dec 19, 2023 · 7 comments
Closed
1 of 3 tasks

Should accept Uint8Array as Array / data or bytes type #1553

arboleya opened this issue Dec 19, 2023 · 7 comments
Labels
feat Issue is a feature

Comments

@arboleya
Copy link
Member

arboleya commented Dec 19, 2023

It's a pain having to convert between all kinds of array / bytes types. We should consider a connonical way to encode/decode between data and accept common forms of data like Uint8Arrays.

Steps

@arboleya arboleya added the feat Issue is a feature label Dec 19, 2023
@arboleya arboleya added this to the 2 - Beetle milestone Jan 8, 2024
@arboleya arboleya modified the milestones: 2 - Beetle, 3 - Wasp, 4 - Cricket Jan 31, 2024
@arboleya arboleya added the p1 label Jun 9, 2024
@arboleya arboleya added this to the 0.x post-launch milestone Jun 12, 2024
@danielbate
Copy link
Contributor

I suspect this was resolved by the changes here and here as I can't see any other type that should accept bytes/array in this way, any thoughts @FuelLabs/sdk-ts?

@arboleya
Copy link
Member Author

@danielbate Did you see this comment? It seems related.

@arboleya arboleya added p2 and removed p1 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya added p1 and removed p2 labels Jul 19, 2024
@danielbate
Copy link
Contributor

That seems related to typegen, re #2784

@arboleya arboleya removed the p1 label Aug 2, 2024
@arboleya arboleya modified the milestone: Caterpillar v1 Aug 2, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Aug 5, 2024
@Dhaiwat10 Dhaiwat10 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@Dhaiwat10 Dhaiwat10 removed their assignment Aug 21, 2024
@arboleya
Copy link
Member Author

@Dhaiwat10 Closed as not planned?

@Dhaiwat10
Copy link
Member

@arboleya I closed this via Linear as 'canceled', since the team decided that we will not be working on this issue at the moment

@arboleya
Copy link
Member Author

Could you please summarize the reasoning behind the decision?

Copy link
Member

@anderson.arboleya sure:

The team decided that working on this issue will require a lot of work deep down the codebase of the abi-coder/typegen. It will probably require a significant amount of refactoring as well. The team decided that it is a better idea to not work on this right now so that we can focus on other priority issues, and to avoid any breaking changes at this moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants