Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming method call to submit #1452

Open
arboleya opened this issue Nov 25, 2023 · 4 comments
Open

Consider renaming method call to submit #1452

arboleya opened this issue Nov 25, 2023 · 4 comments
Labels
feat Issue is a feature

Comments

@arboleya
Copy link
Member

arboleya commented Nov 25, 2023

Follows the ideas from:

We must first check for any problem or incoherence before renaming all call methods to submit.

The goal is to achieve improved semantics.

Note

Validate the impact of breaking changes with the @FuelLabs/frontend team.

@arboleya arboleya changed the title Consider renaming method call to submit for sending pre-assembled transactions Consider renaming method call to submit Nov 25, 2023
@LuizAsFight
Copy link
Contributor

what happens with callParams?

@LuizAsFight
Copy link
Contributor

it's not a problem to be a breaking change if it makes sense and implement a consistent pattern across sdk

@danielbate
Copy link
Contributor

danielbate commented Nov 28, 2023

We could also rename call -> submit but maintain the API, and keep a call function that calls submit if we are concerned about a breaking change. And annotate the deprecation.

@arboleya
Copy link
Member Author

@LuizAsFight Good point.

Maybe something like requestParams() and submit() could work well together.

@Torres-ssf Torres-ssf added chore Issue is a chore and removed refactor labels Dec 8, 2023
@maschad maschad removed the mainnet label Apr 8, 2024
@arboleya arboleya added the p1 label Jun 9, 2024
@arboleya arboleya added this to the 1. caterpillar milestone Jun 9, 2024
@arboleya arboleya added feat Issue is a feature p0 and removed chore Issue is a chore feat Issue is a feature p1 labels Jun 12, 2024
@arboleya arboleya removed this from the 1.0 caterpillar milestone Jul 19, 2024
@arboleya arboleya removed the p0 label Aug 2, 2024
@arboleya arboleya added this to the Caterpillar v1 milestone Aug 2, 2024
@arboleya arboleya removed this from the Caterpillar v1 milestone Sep 7, 2024
@arboleya arboleya added the temp:notion label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

5 participants