Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull remote contract ABI #749

Closed
Tracked by #502
0xmovses opened this issue Apr 9, 2023 · 1 comment · Fixed by #775
Closed
Tracked by #502

Pull remote contract ABI #749

0xmovses opened this issue Apr 9, 2023 · 1 comment · Fixed by #775
Assignees
Milestone

Comments

@0xmovses
Copy link
Contributor

0xmovses commented Apr 9, 2023

No description provided.

@ra0x3
Copy link
Contributor

ra0x3 commented Apr 10, 2023

Will add some context here:

  • Regardless of which way (mentioned below) we go about this, we'll need a new plugin command for this
  • The proper way to do this would be to download the contract ABI asset from the forc package registry
  • However, until that is up and stable, something simple like just downloading for a given endpoint might be ok
    • Assuming that the dev using this functionality is aware that they're trusting the source at the URI
    • If someone uses this "arbitrary" download functionality, might help to make them past a --trust flag or have some type of "You are downloading an arbitrary file, you sure you want to do this?" y/N type of message
  • User should be able to provide a destination path to which the file will be downloaded
  • This will also require updates/docs in the book

Extras

  • Possibly downloading more than just the ABI

@0xmovses 0xmovses self-assigned this Apr 13, 2023
@ra0x3 ra0x3 added this to the Beta-4.5 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants