Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all HTTP endpoints to fail gracefully #215

Closed
ra0x3 opened this issue Sep 14, 2022 · 0 comments · Fixed by #222
Closed

Allow all HTTP endpoints to fail gracefully #215

ra0x3 opened this issue Sep 14, 2022 · 0 comments · Fixed by #222
Assignees
Labels

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Sep 14, 2022

  • We're currently using a bit of panic/expect logic on web API routes
  • The server should not stop if anything goes wrong with an HTTP request
  • We should allow all requests to fail gracefully, log errors, and return a generic INTERNAL_SERVER_ERROR

Additional context

@deekerno deekerno self-assigned this Sep 14, 2022
@ra0x3 ra0x3 linked a pull request Sep 19, 2022 that will close this issue
1 task
@ra0x3 ra0x3 assigned ra0x3 and unassigned deekerno Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants