Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate web server, GraphQL layer, and data layer #1145

Open
1 of 5 tasks
ra0x3 opened this issue Jul 25, 2023 · 2 comments
Open
1 of 5 tasks

Integrate web server, GraphQL layer, and data layer #1145

ra0x3 opened this issue Jul 25, 2023 · 2 comments
Assignees
Labels
big breaking This is a change that will break some component of the project once merged to origin/develop

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Jul 25, 2023

  • We ideally want to keep GraphQL usage on the web API
    • We're using GraphQL syntax to define our data models (regardless of the outcome of this issue) so it would be nice to stay consistent, and other projects at Fuel use GraphQL
  • In order to avoid Remove GraphQL web API #1066, we need to figure out some way to integrate our web server (axum), our GraphQL usage (async-graphql), and our data layer (sqlx)
  • The Graph solved for this by just hand-rolling everything
  • We will most likely have to do the same
  • Although we maybe won't be able to use their graph-graphql crate, we could most definitely take inspiration from how they're doing things

Tasks

@ra0x3 ra0x3 added enhancement big breaking This is a change that will break some component of the project once merged to origin/develop and removed breaking This is a change that will break some component of the project once merged to origin/develop labels Jul 25, 2023
@ra0x3 ra0x3 removed the enhancement label Aug 8, 2023
@ra0x3
Copy link
Contributor Author

ra0x3 commented Aug 14, 2023

Steps

Will add more steps as we find them

@ra0x3 ra0x3 added the breaking This is a change that will break some component of the project once merged to origin/develop label Aug 17, 2023
@ra0x3 ra0x3 linked a pull request Sep 5, 2023 that will close this issue
7 tasks
@ra0x3
Copy link
Contributor Author

ra0x3 commented Sep 26, 2023

@deekerno Just an FYI

  • Keep in mind the other two smaller issues in this larger issue ☝🏼
  • I closed them out but we should still integrate them into whatever work you do.
  • They are:
    • Usage of camelCase field definition names in the schema (e.g., account_id becomes accountId)
    • Using snake_case table names for type definitions that are PascalCased (e.g., indexmetadataentity becomes index_metadata_entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big breaking This is a change that will break some component of the project once merged to origin/develop
Projects
None yet
3 participants