Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number.isNaN is not supported in IE 9-10 and some other older browsers #3

Closed
arturi opened this issue May 13, 2017 · 2 comments
Closed

Number.isNaN is not supported in IE 9-10 and some other older browsers #3

arturi opened this issue May 13, 2017 · 2 comments

Comments

@arturi
Copy link

arturi commented May 13, 2017

Hi, thanks for this module! We’ve run into an issue of older versions of IE (11<) choking on this, because they don’t support Number.isNaN.

Could plain old isNaN() be used here? Also, a polyfill exists https://github.com/leonderijke/Number.isNaN, but seems weird to add it for this tiny thing.

Thanks.
@arturi arturi changed the title Number.isNaN is not supported in IE 9-10 and some others Number.isNaN is not supported in IE 9-10 and some other older browsers May 13, 2017
@ungoldman
Copy link
Collaborator

Seems totally reasonable to me to use the older isNaN() function.

ungoldman added a commit to ungoldman/prettier-bytes that referenced this issue May 15, 2017
@ungoldman
fix Flet#3: use old isNaN
9e5d79e
@ungoldman ungoldman mentioned this issue May 15, 2017
Merged
@Flet Flet closed this as completed in #4 May 15, 2017
@Flet
Copy link
Owner

Flet commented May 15, 2017

Fixed in #4

published as prettier-bytes@1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Flet @ungoldman @arturi