Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code for creating "single-task goal conditioned" environments is confusing #394

Closed
krzentner opened this issue Mar 22, 2023 · 0 comments

Comments

@krzentner
Copy link
Contributor

The code used to create metaworld.envs.ALL_V2_ENVIRONMENTS_GOAL_OBSERVABLE and metaworld.envs.ALL_V2_ENVIRONMENTS_GOAL_HIDDEN is highly non-obvious and among other things involves running a regex on the environment name. It should be possible to implement this with a simple for loop and a small wrapper class. The current implementation is here. Fortunately, there are test here, so this change should be fairly easy to make and low-risk.

@krzentner krzentner changed the title The code for creating "single-task goal conditioned" environment is confusing The code for creating "single-task goal conditioned" environments is confusing Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants