From f59b97a6421c85ddb839d0e75f83a596e2534548 Mon Sep 17 00:00:00 2001 From: Christina Dobrzynski <51066321+Christinadobrzyn@users.noreply.github.com> Date: Mon, 6 Sep 2021 15:37:10 +0800 Subject: [PATCH] Update CONTRIBUTING.md Revised some wording under the Finding Jobs section - specific to when a contributor qualifies for a bonus and how to submit a proposal. --- CONTRIBUTING.md | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a1ea12a9d9fb..8500bb7fb753 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -37,15 +37,19 @@ This is the most common scenario for contributors. The Expensify team posts new #### Proposing a job that Expensify hasn’t posted -In this scenario, it’s possible that you found a bug or enhancement that we haven’t posted to the [Upwork job list](https://www.upwork.com/ab/jobs/search/?q=Expensify%20React%20Native&sort=recency&user_location_match=2) or [Github repository](https://github.com/Expensify/App/issues?q=is%3Aissue). This is an opportunity to propose a job, and (optionally) a solution. If it's a valid job proposal that we choose to implement — either internally or via an external contributor — then we will compensate you $250 for identifying and proposing the improvement. Note: If your solution is also merged, this $250 is *in addition to* the price you will be paid for completing the job. +In this scenario, it’s possible that you found a bug or enhancement that we haven’t posted to the [Upwork job list](https://www.upwork.com/ab/jobs/search/?q=Expensify%20React%20Native&sort=recency&user_location_match=2) or [Github repository](https://github.com/Expensify/App/issues?q=is%3Aissue). This is an opportunity to propose a job, and (optionally) a solution. If it's a valid job proposal that we choose to implement — either internally or via an external contributor — then we will compensate you $250 for identifying and proposing the improvement. Note: If your solution is also merged, we will give a $250 bonus for fixing the bug/enhancement. + +How to propose a job in the Expensify/App repo 1. Check to ensure an issue does not already exist in the New Expensify Issue list or Upwork job list. Please use your best judgement to search for similar titles and issue descriptions. 2. If your bug or enhancement matches an existing issue, please feel free to comment on that GitHub issue with your findings if you think it’ll help solve a problem. 3. If there is no existing issue or Upwork job, create a new GitHub issue in the Expensify/App repo. - 4. Make sure to fill out all the required information fields in the issue template. + 4. Fill out the required fields with the details of the bug you've found or enhancement suggestion. 5. Add the `AutoAssignerTriage` label to your issue. - 6. Before starting your PR to solve the bug or enhancement that you are proposing, please add a comment on your issue with a solution proposal. - 7. Pause on this step until a member of the Expensify team responds on your issue with next steps. + 6. Submit the issue. + 7. After the issue is submitted, add a comment to the issue with your proposed solution. + 8. Wait until a member of the Expensify team responds on your issue with next steps. + 9. Start your PR to solve the bug or enhancement. >**Note:** Our problem solving approach at Expensify is to focus on high value problems and avoid small optimizations with results that are difficult to measure. We also prefer to identify and solve problems at their root. Given that, please ensure all proposed jobs fix a specific problem in a measurable way with evidence so they are easy to evaluate. Here's an example of a good problem/solution: > @@ -53,7 +57,7 @@ In this scenario, it’s possible that you found a bug or enhancement that we ha > >**Solution:** Start up time will perceptibly decrease by 1042ms if we prevent the unnecessary re-renders of this component. -## Working on Expensify Jobs +## Working on Expensify Jobs posted in Upwork *Reminder: For technical guidance please refer to the [README](https://github.com/Expensify/App/blob/main/README.md)*. #### Express interest for the job on Upwork.com