From aebf5c39870a5e5a66d345bdc5d9c87d8d8e82ee Mon Sep 17 00:00:00 2001 From: Samil Abud Date: Mon, 27 May 2024 20:35:34 -0400 Subject: [PATCH 1/3] Fixed Desktop - Task - Error occurs when update long content for task description for second time --- src/libs/actions/Task.ts | 2 +- src/pages/tasks/TaskDescriptionPage.tsx | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libs/actions/Task.ts b/src/libs/actions/Task.ts index 1d4415f72f4b..41dab874b495 100644 --- a/src/libs/actions/Task.ts +++ b/src/libs/actions/Task.ts @@ -435,7 +435,7 @@ function reopenTask(taskReport: OnyxEntry) { function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) { // Create the EditedReportAction on the task const editTaskReportAction = ReportUtils.buildOptimisticEditedTaskFieldReportAction({title, description}); - + console.log({editTaskReportAction, len: description?.length}); // Sometimes title or description is undefined, so we need to check for that, and we provide it to multiple functions const reportName = (title ?? report?.reportName)?.trim(); diff --git a/src/pages/tasks/TaskDescriptionPage.tsx b/src/pages/tasks/TaskDescriptionPage.tsx index c48746c81239..7abfaee4d2dd 100644 --- a/src/pages/tasks/TaskDescriptionPage.tsx +++ b/src/pages/tasks/TaskDescriptionPage.tsx @@ -37,9 +37,10 @@ function TaskDescriptionPage({report, currentUserPersonalDetails}: TaskDescripti const validate = useCallback((values: FormOnyxValues): FormInputErrors => { const errors = {}; + const parsedDescription = ReportUtils.getParsedComment(values?.description); - if (values?.description && values.description?.length > CONST.DESCRIPTION_LIMIT) { - ErrorUtils.addErrorMessage(errors, 'description', ['common.error.characterLimitExceedCounter', {length: values.description.length, limit: CONST.DESCRIPTION_LIMIT}]); + if (parsedDescription && parsedDescription?.length > CONST.DESCRIPTION_LIMIT) { + ErrorUtils.addErrorMessage(errors, 'description', ['common.error.characterLimitExceedCounter', {length: parsedDescription.length, limit: CONST.DESCRIPTION_LIMIT}]); } return errors; From c68d70742cfabb299c0233a9bbdea3e4b87a45cf Mon Sep 17 00:00:00 2001 From: Samil Abud Date: Tue, 4 Jun 2024 21:09:07 -0400 Subject: [PATCH 2/3] Fixed eslint issue --- src/libs/actions/Task.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libs/actions/Task.ts b/src/libs/actions/Task.ts index 063ec053838d..a774a4052980 100644 --- a/src/libs/actions/Task.ts +++ b/src/libs/actions/Task.ts @@ -434,7 +434,6 @@ function reopenTask(taskReport: OnyxEntry) { function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) { // Create the EditedReportAction on the task const editTaskReportAction = ReportUtils.buildOptimisticEditedTaskFieldReportAction({title, description}); - console.log({editTaskReportAction, len: description?.length}); // Sometimes title or description is undefined, so we need to check for that, and we provide it to multiple functions const reportName = (title ?? report?.reportName)?.trim(); From a1a6dd741c8ed382e15b7461916f3224a67491d9 Mon Sep 17 00:00:00 2001 From: Samil Abud Date: Fri, 12 Jul 2024 13:53:03 -0400 Subject: [PATCH 3/3] Restoring new line erased (nit) --- src/libs/actions/Task.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/actions/Task.ts b/src/libs/actions/Task.ts index 1162d364f059..964f5be0129b 100644 --- a/src/libs/actions/Task.ts +++ b/src/libs/actions/Task.ts @@ -494,6 +494,7 @@ function reopenTask(taskReport: OnyxEntry) { function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) { // Create the EditedReportAction on the task const editTaskReportAction = ReportUtils.buildOptimisticEditedTaskFieldReportAction({title, description}); + // Sometimes title or description is undefined, so we need to check for that, and we provide it to multiple functions const reportName = (title ?? report?.reportName)?.trim();