From 685169caa4d33d6ed69f1519db7375e7a2b50437 Mon Sep 17 00:00:00 2001 From: someone-here Date: Wed, 14 Jun 2023 17:48:18 +0530 Subject: [PATCH 1/3] Add tooltips and nav to bill details --- src/components/MoneyRequestConfirmationList.js | 14 +++++++++++++- src/components/OptionRow.js | 5 ++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/components/MoneyRequestConfirmationList.js b/src/components/MoneyRequestConfirmationList.js index f8006788bbac..45ffaa6d9a95 100755 --- a/src/components/MoneyRequestConfirmationList.js +++ b/src/components/MoneyRequestConfirmationList.js @@ -228,6 +228,17 @@ function MoneyRequestConfirmationList(props) { [props.session.email], ); + /** + * Navigate to details page of selected user + * @param {Object} option + */ + const navigateToUserDetail = (option) => { + if (!option.login) { + return; + } + Navigation.navigate(ROUTES.getDetailsRoute(option.login)); + }; + /** * @param {String} paymentMethod */ @@ -290,12 +301,13 @@ function MoneyRequestConfirmationList(props) { 1; // We only create tooltips for the first 10 users or so since some reports have hundreds of users, causing performance to degrade. - const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips((this.props.option.participantsList || []).slice(0, 10), isMultipleParticipant); + const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips( + (this.props.option.participantsList || this.props.option.login ? [this.props.option] : []).slice(0, 10), + isMultipleParticipant, + ); let subscriptColor = themeColors.appBG; if (this.props.optionIsFocused) { subscriptColor = focusedBackgroundColor; From 511c2009ed63ea5140f7d33f42e601870550f550 Mon Sep 17 00:00:00 2001 From: someone-here Date: Thu, 15 Jun 2023 21:00:11 +0530 Subject: [PATCH 2/3] DetailsPage -> ProfilePage --- src/components/MoneyRequestConfirmationList.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/MoneyRequestConfirmationList.js b/src/components/MoneyRequestConfirmationList.js index 45ffaa6d9a95..640e8d8d19b1 100755 --- a/src/components/MoneyRequestConfirmationList.js +++ b/src/components/MoneyRequestConfirmationList.js @@ -20,6 +20,7 @@ import MenuItemWithTopDescription from './MenuItemWithTopDescription'; import Navigation from '../libs/Navigation/Navigation'; import optionPropTypes from './optionPropTypes'; import * as CurrencyUtils from '../libs/CurrencyUtils'; +import * as ReportUtils from '../libs/ReportUtils'; const propTypes = { /** Callback to inform parent modal of success */ @@ -236,7 +237,7 @@ function MoneyRequestConfirmationList(props) { if (!option.login) { return; } - Navigation.navigate(ROUTES.getDetailsRoute(option.login)); + Navigation.navigate(ROUTES.getProfileRoute(ReportUtils.getAccountIDForLogin(option.login))); }; /** From b100ee493c7a0089a152481e186a7a368381ce76 Mon Sep 17 00:00:00 2001 From: Esh Tanya Gupta <77237602+esh-g@users.noreply.github.com> Date: Thu, 15 Jun 2023 21:27:01 +0530 Subject: [PATCH 3/3] Ammend comment detail -> profile Co-authored-by: Eugene Voloshchak --- src/components/MoneyRequestConfirmationList.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/MoneyRequestConfirmationList.js b/src/components/MoneyRequestConfirmationList.js index 640e8d8d19b1..5365badce969 100755 --- a/src/components/MoneyRequestConfirmationList.js +++ b/src/components/MoneyRequestConfirmationList.js @@ -230,7 +230,7 @@ function MoneyRequestConfirmationList(props) { ); /** - * Navigate to details page of selected user + * Navigate to profile of selected user * @param {Object} option */ const navigateToUserDetail = (option) => {