Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for ShaderResources #165

Merged
merged 6 commits into from
Feb 28, 2021
Merged

Test for ShaderResources #165

merged 6 commits into from
Feb 28, 2021

Conversation

unexploredtest
Copy link
Contributor

@unexploredtest unexploredtest commented Feb 27, 2021 •
edited
Loading

Created test for ShaderResources.
The tests will pass if the GLSL succeeds/fails compiling the shaders given the situation and resources.

@unexploredtest
Copy link
Contributor Author

@axsaucedo Does it look ok?

axsaucedo
axsaucedo requested changes Feb 28, 2021
View reviewed changes
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a couple of final comments/ questions

test/TestShaderResources.cpp Outdated Show resolved Hide resolved
test/TestShaderResources.cpp Outdated Show resolved Hide resolved
@unexploredtest
Copy link
Contributor Author

unexploredtest commented Feb 28, 2021 •
edited
Loading

I think it's ready.
Should we include details about resources/TBuiltInResource and the defaultResource constant in the documenation?

axsaucedo
axsaucedo approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@axsaucedo axsaucedo merged commit 2834519 into KomputeProject:master Feb 28, 2021
@axsaucedo
Copy link
Member

I think it may be worth adding a mention in the docs, there is now a shader page, so probably there could make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unexploredtest @axsaucedo