Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View snaps to bottom of file when stepping into a function #36

Closed
luis-reyes-a opened this issue Jan 15, 2024 · 6 comments
Closed

View snaps to bottom of file when stepping into a function #36

luis-reyes-a opened this issue Jan 15, 2024 · 6 comments
Labels
Bug A report of unintended or broken behavior.

Comments

@luis-reyes-a
Copy link

Hello, in this clip I'm trying to step into a function. When I do, first it focuses on the disassembly instruction. I step over and it takes takes me to the start of the function. When I step over again, the view scrolls all the way to the bottom of the file. Stepping over again, fixes this and takes me back to where I was in the function.

(I don't think it matters but I'm calling the function through a macro (it doesn't do anything special but some token concatenation to call the function)

2024-01-14_22-42-37.mp4
@ryanfleury
Copy link
Collaborator

Hmm. I think this is two bugs in one. The first, the step-into stopping at the jump table, has been fixed in 5fe3f56. The second is probably a new edge case in line info, so I'll put on my list to check that one out.

@ryanfleury ryanfleury added the Bug A report of unintended or broken behavior. label Jan 18, 2024
@luis-reyes-a
Copy link
Author

Hey Ryan, not sure if it helps but the view snapping to the bottom of the file happens EVERY time I step into a function. Looking at videos of other people using the debugger, it seems to not be the case. I suspect maybe it has to do with the way I laid out my debugger windows or something? Here's another recording of this happening in latest build [28e258b]

(Uploaded to youtube because it's too long for github)
https://youtu.be/DG7Wgvef-hI

@ryanfleury
Copy link
Collaborator

I don't think it should have anything to do with the panel layout you have. Can you provide more information about how you're building your EXE - what compiler, what version, what flags, what linker, etc.? And, if possible, can you send me a small test EXE/PDB which minimally reproduces the issue on your end?

@luis-reyes-a
Copy link
Author

To build raddebugger, I'm using msvc 19.29.30133 and all I do is go to the root folder and run build.bat.

I suspect it may be because the program I'm trying to debug is using msbuild. I tried to recreate the problem just making a build.bat that calls cl but couldn't make it happen. Making a project in visual studio and calling msbuild did it for me. I think it also only happens when you jump to a function in a different file. Here is an example project. Just step into the function calls I have in main()

example.zip

@ryanfleury
Copy link
Collaborator

Looks like this is because of the /JMC (Just My Code) option, which is presumably turned on by default with the usual msbuild setup. Looking into how the debugger ought to handle this.

@ryanfleury
Copy link
Collaborator

This should be resolved in f130f23. Let me know if you run into additional issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A report of unintended or broken behavior.
Projects
None yet
Development

No branches or pull requests

2 participants