Config option to specify MessageTypesDiscardForQueueing #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
Pietfried
force-pushed
the
feature/message-queue-offline-queueing-config
branch
2 times, most recently
from
4a84a97
to
c085334
Compare
hikinggrass
approved these changes
Sep 5, 2024
…llMessages. A new config option MessageTypesDiscardForQueueing has been introduced. It is a comma seperated list of message types that shall not be queued (when offline) even in case QueueAllMessages is true. If QueueAllMessages is false, the configuration of this paramater has no effect. The message queue will discard all message type listed as part of this value except for transaction-related message types. This feature has been implemented for OCPP1.6 and OCPP2.0.1 Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
force-pushed
the
feature/message-queue-offline-queueing-config
branch
from
c085334
to
3de6729
Compare
3 tasks
Pietfried
added a commit
to EVerest/everest-core
that referenced
this pull request
Sep 6, 2024
…fig option implemented in EVerest/libocpp#765 Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
added a commit
to EVerest/everest-core
that referenced
this pull request
Sep 6, 2024
…fig option implemented in EVerest/libocpp#765 (#858) Signed-off-by: pietfried <pietgoempel@gmail.com>
SNSubramanya
pushed a commit
that referenced
this pull request
Sep 11, 2024
…llMessages. A new config option MessageTypesDiscardForQueueing has been introduced. It is a comma seperated list of message types that shall not be queued (when offline) even in case QueueAllMessages is true. If QueueAllMessages is false, the configuration of this paramater has no effect. The message queue will discard all message type listed as part of this value except for transaction-related message types. This feature has been implemented for OCPP1.6 and OCPP2.0.1 (#765) Signed-off-by: pietfried <pietgoempel@gmail.com> Signed-off-by: Soumya Subramanya <s.subramanya@alfen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR implements a feature and additional config option in addtion to QueueAllMessages.
A new config option MessageTypesDiscardForQueueing has been introduced. It is a comma seperated list of message types that shall not be queued (when offline) even in case QueueAllMessages is true. If QueueAllMessages is false, the configuration of this paramater has no effect. The message queue will discard all message type listed as part of this value except for transaction-related message types. This feature has been implemented for OCPP1.6 and OCPP2.0.1.
Issue ticket number and link
Checklist before requesting a review