-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single-point matrixCN fails #2840
base: cesm3_0_beta04_changes
Are you sure you want to change the base?
Fix single-point matrixCN fails #2840
Conversation
Rebase to cesm3_0_beta04_changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Just needs to be done elsewhere as well≥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We realized this should be done elsewhere, so I'll look at it again when this is done to approve again.
Testing on derecho and izumi in prep for merge: |
@ekluzek this is ready for me to merge with your approval. |
Description of changes
Change SparseMatrixMultiplyMod.F90 line 1246:
SHR_ASSERT_FL((size(filter_actunit_C) > num_actunit_C), sourcefile, __LINE__)
to
SHR_ASSERT_FL((size(filter_actunit_C) >= num_actunit_C), sourcefile, __LINE__)
to help some failing matrixCN tests pass.
Specific notes
Contributors other than yourself, if any:
@ekluzek
CTSM Issues Fixed (include github issue #):
Fix #2780
Are answers expected to change (and if so in what way)?
No.
Any User Interface Changes (namelist or namelist defaults changes)?
No.
Does this create a need to change or add documentation? Did you do so?
No.
Testing performed, if any:
Failing tests now pass (see issue #2780).