Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnmatrix solver crashes depending on the finidat file, as well as in an IHist simulation #2592

Open
slevis-lmwg opened this issue Jun 7, 2024 · 1 comment
Labels
bug something is working incorrectly investigation Needs to be verified and more investigation into what's going on. priority: low Background task that doesn't need to be done right away.

Comments

@slevis-lmwg
Copy link
Contributor

Summary:

  • cnmatrix may crash when given a finidat file from a different simulation, even when using init_interp.
  • cnmatrix may also crash in transient simulations.

Details:
I have encountered three examples this far (see #640):

  1. I2000 test using the original ctsm5.2 f19 finidat file:
  1. NEON-NIWO single-point test with (ironically) the new ctsm5.2 f19 finidat file described in (1):
  • I reran the test with the orig. ctsm5.2 f19 finidat file and it passed.
  • The problem may be similar to (1)
  • In this case we decided to replace the failing test with a NEON-HARV test, which is a better site to support than NIWO anyway according to @wwieder. This one works with the new ctsm5.2 f19 finidat file described in (1).
  1. To spin up the model (see 1), I tried running all the phases (except AD) with cnmatrix; however, cnmatrix crashed in the historical simulation early in year 1901. The problem may be similar to (1).

Recommendations:

  • It seems safest to perform a unique spin-up for each single-point site and for each model resolution.
  • Also cnmatrix may be most useful in SASU mode because it results in much faster model spin-up.
  • Transient simulations with cnmatrix may not work.

General bug information

CTSM version you are using:
I'm using the cnmatrix branch (#640).
The PR's notes show when the above issues emerged.

Configurations affected:
cnmatrix

@slevis-lmwg slevis-lmwg added priority: low Background task that doesn't need to be done right away. investigation Needs to be verified and more investigation into what's going on. bug something is working incorrectly labels Jun 7, 2024
@slevis-lmwg
Copy link
Contributor Author

If these crashes occur consistently due to newly emerging pfts:

  1. They may indicate a problem that has remained hidden until now.
  2. We may wish to introduce a more graceful error message suggesting a cold start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly investigation Needs to be verified and more investigation into what's going on. priority: low Background task that doesn't need to be done right away.
Projects
None yet
Development

No branches or pull requests

1 participant