From af7d0549a74b17424e8aedfd321d68da51574272 Mon Sep 17 00:00:00 2001 From: YangHau Date: Thu, 23 May 2019 15:26:29 +0800 Subject: [PATCH] fix(reg): Remove useless error return and logging Use list pass_case to recode which cases are passing cases. --- tests/regression/runner.py | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/tests/regression/runner.py b/tests/regression/runner.py index e1cd9ef2..4b2cc4c4 100644 --- a/tests/regression/runner.py +++ b/tests/regression/runner.py @@ -142,8 +142,6 @@ def test_mam_send_msg(self): response[i][0] + ", status code = " + response[i][1]) for i in range(len(response)): - logging.debug("send msg i = " + str(i) + ", res = " + - response[i][0] + ", status code = " + response[i][1]) if i in pass_case: res_json = json.loads(response[i][0]) self.assertTrue(valid_trytes(res_json["channel"], LEN_ADDR)) @@ -188,8 +186,6 @@ def test_mam_recv_msg(self): pass_case = [0] for i in range(len(test_cases)): - logging.debug("recv msg i = " + str(i) + ", res = " + - response[i][0] + ", status code = " + response[i][1]) if i in pass_case: self.assertTrue(expect_cases[i] in response[i][0]) else: @@ -263,8 +259,6 @@ def test_send_transfer(self): pass_case = [0, 1, 2, 3] for i in range(len(response)): - logging.debug("send transfer i = " + str(i) + ", res = " + - response[i][0] + ", status code = " + response[i][1]) if i in pass_case: res_json = json.loads(response[i][0]) @@ -353,11 +347,9 @@ def test_find_transactions_by_tag(self): logging.debug("find transactions by tag i = " + str(i) + ", res = " + response[i][0] + ", status code = " + response[i][1]) + pass_case = [0, 1] for i in range(len(response)): - logging.debug("find transactions by tag i = " + str(i) + - ", res = " + response[i][0] + ", status code = " + - response[i][1]) - if i == 0 or i == 1: + if i in pass_case: tx_res_json = json.loads(transaction_response[i][0]) res_json = json.loads(response[i][0]) @@ -417,11 +409,9 @@ def test_get_transactions_object(self): ", res = " + repr(response[i][0]) + ", status code = " + repr(response[i][1])) + pass_case = [0] for i in range(len(response)): - logging.debug("get transactions object i = " + str(i) + - ", res = " + repr(response[i][0]) + - ", status code = " + repr(response[i][1])) - if i == 0: + if i in pass_case: res_json = json.loads(response[i][0]) self.assertEqual(sent_transaction_hash, res_json["hash"]) else: @@ -461,6 +451,3 @@ def test_get_transactions_object(self): else: logging.basicConfig(level=logging.INFO) unittest.main(argv=['first-arg-is-ignored'], exit=True) - - if len(unittest.TestResult().errors) != 0: - exit(1)