From d7d71555fbc5a13d74c2cb3fe50bbefc6e1c166e Mon Sep 17 00:00:00 2001 From: Cris Luengo Date: Thu, 12 Aug 2021 08:55:18 -0600 Subject: [PATCH] Fixed typo in libics that caused out-of-bounds read. Fixes #81. --- changelogs/diplib_3.1.0.md | 2 ++ dependencies/libics/libics_read.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/changelogs/diplib_3.1.0.md b/changelogs/diplib_3.1.0.md index 44e27e0be..b39bc8d60 100644 --- a/changelogs/diplib_3.1.0.md +++ b/changelogs/diplib_3.1.0.md @@ -100,6 +100,8 @@ title: "Changes DIPlib 3.1.0" - `dip::MeanAbs()` and `dip::SumAbs()` could produce wrong results for complex inputs. +- libics had a typo that caused out-of-bounds read (#81). + diff --git a/dependencies/libics/libics_read.c b/dependencies/libics/libics_read.c index 3605c4ccb..b02beae82 100644 --- a/dependencies/libics/libics_read.c +++ b/dependencies/libics/libics_read.c @@ -897,7 +897,7 @@ Ics_Error IcsReadIcs(Ics_Header *icsStruct, for (sj = 0, si = 0; si < parameters; si++) { if (si == bits) { icsStruct->imel.origin = origin[si]; - icsStruct->imel.scale = scale[i]; + icsStruct->imel.scale = scale[si]; strcpy(icsStruct->imel.unit, unit[si]); } else { icsStruct->dim[sj].size = sizes[si];