From 12b90d5ecfb0bd72b871f659bd4228a05c2d01a1 Mon Sep 17 00:00:00 2001
From: Carlos Matos <carlos.matos@crowdstrike.com>
Date: Thu, 8 Aug 2024 14:53:45 -0400
Subject: [PATCH] chore(falconctl): remove provisioning_token, not needed

After testing some more, realized that the reason we didn't get this
option is because it doesn't make sense due to the way it behaves.
---
 molecule/falcon_configure_remove_aid/molecule.yml | 1 +
 molecule/falcon_configure_remove_aid/verify.yml   | 6 ------
 plugins/module_utils/falconctl_utils.py           | 1 -
 plugins/modules/falconctl.py                      | 2 +-
 plugins/modules/falconctl_info.py                 | 1 -
 5 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/molecule/falcon_configure_remove_aid/molecule.yml b/molecule/falcon_configure_remove_aid/molecule.yml
index e7b2d172..72f1b485 100644
--- a/molecule/falcon_configure_remove_aid/molecule.yml
+++ b/molecule/falcon_configure_remove_aid/molecule.yml
@@ -29,5 +29,6 @@ scenario:
     - create
     - prepare
     - converge
+    - idempotence
     - verify
     - destroy
diff --git a/molecule/falcon_configure_remove_aid/verify.yml b/molecule/falcon_configure_remove_aid/verify.yml
index 977667de..8284ea6c 100644
--- a/molecule/falcon_configure_remove_aid/verify.yml
+++ b/molecule/falcon_configure_remove_aid/verify.yml
@@ -13,7 +13,6 @@
     ansible.builtin.assert:
       that:
         - info_verify.falconctl_info.cid
-        - info_verify.falconctl_info.provisioning_token
         - info_verify.falconctl_info.tags
 
   - name: Verify AID is not present
@@ -43,11 +42,6 @@
       that:
         - new_info_verify.falconctl_info.aid
 
-  - name: Validate Provisioning Token is not present
-    ansible.builtin.assert:
-      that:
-        - not new_info_verify.falconctl_info.provisioning_token
-
   - name: Validate CID and Tags are still present
     ansible.builtin.assert:
       that:
diff --git a/plugins/module_utils/falconctl_utils.py b/plugins/module_utils/falconctl_utils.py
index 5b75b5e1..0940fbc9 100644
--- a/plugins/module_utils/falconctl_utils.py
+++ b/plugins/module_utils/falconctl_utils.py
@@ -29,7 +29,6 @@
     "message_log",
     "billing",
     "tags",
-    'provisioning_token',
     "version",
     "rfm_state",
     "rfm_reason",
diff --git a/plugins/modules/falconctl.py b/plugins/modules/falconctl.py
index 392f01be..2cd46b61 100644
--- a/plugins/modules/falconctl.py
+++ b/plugins/modules/falconctl.py
@@ -351,7 +351,7 @@ def main():  # pylint: disable=missing-function-docstring
     module_args = dict(
         state=dict(required=True, choices=["absent", "present"], type="str"),
         cid=dict(required=False, type="str"),
-        provisioning_token=dict(required=False, no_log=True, type="str"),
+        provisioning_token=dict(required=False, type="str"),
         aid=dict(required=False, type="bool"),
         apd=dict(required=False, type="str"),
         aph=dict(required=False, type="str"),
diff --git a/plugins/modules/falconctl_info.py b/plugins/modules/falconctl_info.py
index 9e17c086..b9eb5b90 100644
--- a/plugins/modules/falconctl_info.py
+++ b/plugins/modules/falconctl_info.py
@@ -38,7 +38,6 @@
         'message_log',
         'billing',
         'tags',
-        'provisioning_token',
         'version',
         'rfm_state',
         'rfm_reason',