From 0559c94f8c64590e487ff2ff0daea75c9d2f6022 Mon Sep 17 00:00:00 2001 From: Remco de Boer Date: Thu, 10 Jun 2021 16:33:44 +0200 Subject: [PATCH 1/2] fix: lambdify argument of sqrt --- docs/report/001.ipynb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/report/001.ipynb b/docs/report/001.ipynb index 862ac83c..958a2b04 100644 --- a/docs/report/001.ipynb +++ b/docs/report/001.ipynb @@ -414,7 +414,9 @@ " _module = \"jax\"\n", "\n", " def _print_ComplexSqrt(self, expr: sp.Expr) -> str:\n", - " return \"select([less(x, 0), True], [1j * sqrt(-x), sqrt(x)], default=nan,)\"" + " arg = expr.args[0]\n", + " x = self._print(arg)\n", + " return f\"select([less({x}, 0), True], [1j * sqrt(-{x}), sqrt({x})], default=nan,)\"" ] }, { From db89e280ecda10820ddb5e45cf2ae40f1528482b Mon Sep 17 00:00:00 2001 From: Remco de Boer Date: Thu, 10 Jun 2021 16:34:10 +0200 Subject: [PATCH 2/2] docs: add links to corresponding issues --- docs/report/000.ipynb | 11 +++++++++++ docs/report/001.ipynb | 11 +++++++++++ docs/report/002.ipynb | 11 +++++++++++ 3 files changed, 33 insertions(+) diff --git a/docs/report/000.ipynb b/docs/report/000.ipynb index 9495740c..8979a3ac 100644 --- a/docs/report/000.ipynb +++ b/docs/report/000.ipynb @@ -16,6 +16,17 @@ "" ] }, + { + "cell_type": "markdown", + "metadata": {}, + "source": [ + ":::{note}\n", + "\n", + "This report has been implemented in [ComPWA/tensorwaves#284](https://github.com/ComPWA/tensorwaves/pull/284).\n", + "\n", + ":::" + ] + }, { "cell_type": "markdown", "metadata": {}, diff --git a/docs/report/001.ipynb b/docs/report/001.ipynb index 958a2b04..19228112 100644 --- a/docs/report/001.ipynb +++ b/docs/report/001.ipynb @@ -7,6 +7,17 @@ "# [TR-001] Custom lambdification" ] }, + { + "cell_type": "markdown", + "metadata": {}, + "source": [ + ":::{note}\n", + "\n", + "This report has been implemented in [ComPWA/ampform#72](https://github.com/ComPWA/ampform/pull/72) and [ComPWA/ampform#284](https://github.com/ComPWA/tensorwaves/pull/284).\n", + "\n", + ":::" + ] + }, { "cell_type": "markdown", "metadata": {}, diff --git a/docs/report/002.ipynb b/docs/report/002.ipynb index bc4464b3..e78723fe 100644 --- a/docs/report/002.ipynb +++ b/docs/report/002.ipynb @@ -14,6 +14,17 @@ "" ] }, + { + "cell_type": "markdown", + "metadata": {}, + "source": [ + ":::{note}\n", + "\n", + "This report has been implemented in [ComPWA/tensorwaves#281](https://github.com/ComPWA/tensorwaves/pull/281).\n", + "\n", + ":::" + ] + }, { "cell_type": "code", "execution_count": null,