Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community package requirements: sanity tests and repository management #142

Open
gotmax23 opened this issue Aug 22, 2024 · 6 comments
Open

Comments

@gotmax23
Copy link

(Note: This issue was filed in a semi-automated fashion on behalf of the Ansible Community Steering Committee. Let me know if you see errors in this issue.)

As per the Ansible community package inclusion requirements, collections must pass ansible-test sanity tests. Version 5.2.3 of check_point.mgmt, corresponding to the v5.2.3 tag in this repo, fails one or more of the required sanity tests.

The contents in the v5.2.3 git tag do not match check_point-mgmt-5.2.3.tar.gz as uploaded to Ansible Galaxy. For future releases, please make sure that the contents uploaded to Galaxy match the sources that were tagged as that release. See the Repository management requirements for more information.

Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to removal from Ansible.

Thank you for your efforts and for being part of the Ansible package! We appreciate it.


Sanity tests

The following tests were run using ansible-test version 2.17.3:

  • ansible-doc
  • compile
  • validate-modules
  • yamllint

Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI.

Results

💡 NOTE:

Check the [explain] links below for more information about each test and how to fix failures.
See Sanity Tests: Ignores in the dev guide if, after reading the test-specific documentation, you still believe an error is a false positive.

The test ansible-test sanity --test validate-modules [explain] failed with 261 errors:

[Issue truncated. See full results at https://github.com/ansible-community/package-test-results/blob/main/rendered/10.3.0/check_point.mgmt.md#results]

File divergences

The following files differ between the v5.2.3 git tag and check_point-mgmt-5.2.3.tar.gz on Ansible Galaxy:

  • plugins/module_utils/checkpoint.py (WRONG_HASH)
  • changelogs/.plugin-cache.yaml (WRONG_HASH)
  • changelogs/changelog.yaml (WRONG_HASH)
  • CHANGELOG.rst (WRONG_HASH)
@gotmax23
Copy link
Author

This is a follow up to #121, run against the latest version of ansible-core. Thank you for fixing the first issue so promptly! It looks like most of the issues here are caused by ansible/ansible@92d2c66#diff-2a423d6bc335536285d838786c00ea33a1361e6f5bde5746aa01d79a8d7cea34L179-L186 which removed CertificateError from the ansible.modules_utils.urls which this collection incidentally relied on.

Thanks again for being part of the Ansible package.

@chkp-edenbr
Copy link
Contributor

Hi,
I wasn't able to replicate the issue on our latest release v6.1.1, seems like the files have the same md5 and the collection passed sanity tests.

@gotmax23
Copy link
Author

Did you run the tests with the same version of ansible-core (2.17.3) that was used above? Please also make sure that you are running the required CI tests in this repository as explained in https://docs.ansible.com/ansible/devel/community/collection_contributors/collection_requirements.html#ci-testing.

@chkp-edenbr
Copy link
Contributor

Yes, and there aren't 261 errors as mentioned when running ansible's sanity tests

@gotmax23
Copy link
Author

How are you running the tests? What's the value of ansible-test --version?

@chkp-edenbr
Copy link
Contributor

Re you running the test on the latest version and receiving those errors mentioned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants