Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize BLS signatures from APIs #5739

Closed
twoeths opened this issue Jul 9, 2023 · 2 comments · Fixed by #5754
Closed

Prioritize BLS signatures from APIs #5739

twoeths opened this issue Jul 9, 2023 · 2 comments · Fixed by #5754
Assignees
Labels
meta-feature-request Issues to track feature requests.

Comments

@twoeths
Copy link
Contributor

twoeths commented Jul 9, 2023

Problem description

When gossip blocks are late, node has to download block through beacon_block_by_root

Screenshot 2023-07-09 at 21 07 09

gossip attestations have to be reprocessed at the same time which send too many signature sets to bls worker thread pool, job length is consistently at >= 500

Screenshot 2023-07-09 at 21 12 44

which cause bls job wait time to be very high during that time

Screenshot 2023-07-09 at 21 13 08

which cause sumitPoolAttestations time to be very high too

Screenshot 2023-07-09 at 21 15 02

the submission was late so attestations are not included in any AggregateAndProof (below is timely_target_no_aggregate_inclusion type in attestation performance summary panel)

Screenshot 2023-07-09 at 21 17 54

Solution description

root cause of the issue is gossip performance, however we could prioritize verifying bls signatures from submitPoolAttestations api

with #5734, it should take <7ms per slot to validate 64 signature sets of same attestation data, we could consider verifyOnMainThread option for submitPoolAttestations api

Additional context

No response

@twoeths twoeths added the meta-feature-request Issues to track feature requests. label Jul 9, 2023
@twoeths
Copy link
Contributor Author

twoeths commented Jul 9, 2023

this is also related to #5416 where we can filter api attestations of the same attestation data and validate them in batch in order to use new api in #5734

@twoeths
Copy link
Contributor Author

twoeths commented Jul 10, 2023

an alternative would be to insert to the jobs queue of worker pool at index 0 instead of to append to it

@twoeths twoeths changed the title prioritize bls signatures from submitPoolAttestations api Prioritize BLS signatures from API Jul 10, 2023
@twoeths twoeths changed the title Prioritize BLS signatures from API Prioritize BLS signatures from APIs Jul 10, 2023
@twoeths twoeths self-assigned this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant