Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fork choice to 0.9.1 spec #556

Closed
1 of 2 tasks
mpetrunic opened this issue Nov 15, 2019 · 4 comments
Closed
1 of 2 tasks

Update fork choice to 0.9.1 spec #556

mpetrunic opened this issue Nov 15, 2019 · 4 comments
Assignees
@twoeths

Comments

@mpetrunic
Copy link
Member

mpetrunic commented Nov 15, 2019 •
edited by wemeetagain
Loading

@twoeths twoeths self-assigned this Nov 15, 2019
@twoeths
Copy link
Contributor

twoeths commented Nov 15, 2019

Refer to:

@twoeths twoeths mentioned this issue Nov 18, 2019
Merged
@twoeths
Copy link
Contributor

twoeths commented Nov 28, 2019

@wemeetagain I remember you have some concern/question regarding this, what is it about?

@wemeetagain
Copy link
Member

I think our #559 only tackled ethereum/consensus-specs#1466, must pointing out we would want to integrate ethereum/consensus-specs#1465 too

@twoeths
Copy link
Contributor

twoeths commented Nov 29, 2019

Oh I thought that 1465 was not applicable to our implementation but maybe I was wrong. Need to look into the 2 implementations and compare ...

@twoeths twoeths mentioned this issue Nov 30, 2019
Merged
@twoeths twoeths closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoeths twoeths

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wemeetagain @mpetrunic @twoeths