Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAllAncestorBlocks should not return the self block #4546

Open
nazarhussain opened this issue Sep 14, 2022 · 1 comment
Open

getAllAncestorBlocks should not return the self block #4546

nazarhussain opened this issue Sep 14, 2022 · 1 comment
Assignees
Labels
meta-bug Issues that identify a bug and require a fix. meta-investigate Issues found that require further investigation and may not have a specific resolution/fix prio-low This is nice to have.

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented Sep 14, 2022

Describe the bug

Currently when the forkchoice.getAllAncestorBlocks is called with a block root. The resulting array contains the block itself as well.

Expected behavior

Any block is not an ancestor to itself so should not be part of the result for forkchoice.getAllAncestorBlocks.

Steps to Reproduce

const head = forkchoice.getHead();
const result = forkchoice.getAllAncestorBlocks(head)

// Check if the result contains the head or not

Desktop (please complete the following information):

  • Branch: [unstable]
  • Commit hash: 0886d75
@philknows philknows added prio-low This is nice to have. meta-investigate Issues found that require further investigation and may not have a specific resolution/fix meta-bug Issues that identify a bug and require a fix. labels Nov 5, 2023
@philknows
Copy link
Member

For review along with #6008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix. meta-investigate Issues found that require further investigation and may not have a specific resolution/fix prio-low This is nice to have.
Projects
None yet
Development

No branches or pull requests

3 participants