Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libp2p-ts types #2167

Closed
wemeetagain opened this issue Mar 12, 2021 · 2 comments · Fixed by #2254
Closed

Remove libp2p-ts types #2167

wemeetagain opened this issue Mar 12, 2021 · 2 comments · Fixed by #2254
Assignees

Comments

@wemeetagain
Copy link
Member

Is your feature request related to a problem? Please describe.

We're maintaining our own hand-crafted types separately from many of the libp2p dependencies.
This is a maintenance burden and leads to problems when the types are subtlely wrong, outdated, or incomplete.
It would be much better if long-term, we use the upstream types, pushing our types upstream as necessary.

Describe the solution you'd like

Remove libp2p-ts
Debug and fix type issues as they arise
Push types upstream
Only maintain types locally (within this monorepo) as needed

Describe alternatives you've considered

Status quo.

Additional context

See things like: #2164 (comment)

@vasco-santos
Copy link
Contributor

FYI I am doing a new iteration on libp2p core with the latest developments in aegir libp2p/js-libp2p#904

@dapplion
Copy link
Contributor

@vasco-santos
12nkvn (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants