Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove offline pruner once online pruner is fast enough #2855

Open
qdm12 opened this issue Sep 22, 2022 · 0 comments
Open

Remove offline pruner once online pruner is fast enough #2855

qdm12 opened this issue Sep 22, 2022 · 0 comments

Comments

@qdm12
Copy link
Contributor

qdm12 commented Sep 22, 2022

The main reason the offline pruner is kept is because online pruning has an impact on performance.
The offline pruning does add some complexity in the code and even ourselves wondered for a long time why it was here.

Once #2854 is done, we should test the performance of the node with and without online pruning.
If impact is (as I would expect) minimal, we can remove the offline pruning feature/code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants