Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/utils: Handle errors gracefully instead of calling os.Exit #2387

Closed
qdm12 opened this issue Mar 17, 2022 · 1 comment
Closed

tests/utils: Handle errors gracefully instead of calling os.Exit #2387

qdm12 opened this issue Mar 17, 2022 · 1 comment
Assignees
@qdm12

Comments

@qdm12
Copy link
Contributor

qdm12 commented Mar 17, 2022

Task summary

  • Change to be made in RunGossamer: return error instead of os.Exit
  • Change to be made in InitializeAndStartNodes: return error and teardown nodes on error
  • Change to be made in InitializeAndStartNodesWebsocket: return error and teardown nodes on error

Created from #2326
@qdm12 qdm12 added the tests label Mar 17, 2022
@qdm12 qdm12 self-assigned this Mar 17, 2022
@qdm12 qdm12 mentioned this issue Mar 31, 2022
Merged
@qdm12
Copy link
Contributor Author

qdm12 commented Apr 11, 2022

Done in #2452

@qdm12 qdm12 closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qdm12 qdm12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danforbes @qdm12