From c061b3582eb2fad4b5f077c25925b5043b52290a Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Fri, 17 Jun 2022 11:40:56 -0400 Subject: [PATCH] fix(wasmer): fix flaky sort in `Test_ext_crypto_sr25519_public_keys_version_1` (#2607) --- lib/runtime/wasmer/imports_test.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/runtime/wasmer/imports_test.go b/lib/runtime/wasmer/imports_test.go index 12b5ec5397..3e28ccd062 100644 --- a/lib/runtime/wasmer/imports_test.go +++ b/lib/runtime/wasmer/imports_test.go @@ -1073,7 +1073,7 @@ func Test_ext_crypto_sr25519_public_keys_version_1(t *testing.T) { ks, _ := inst.ctx.Keystore.GetKeystore(idData) require.Equal(t, 0, ks.Size()) - size := 5 + const size = 5 pubKeys := make([][32]byte, size) for i := range pubKeys { kp, err := sr25519.GenerateKeypair() @@ -1083,7 +1083,9 @@ func Test_ext_crypto_sr25519_public_keys_version_1(t *testing.T) { copy(pubKeys[i][:], kp.Public().Encode()) } - sort.Slice(pubKeys, func(i int, j int) bool { return pubKeys[i][0] < pubKeys[j][0] }) + sort.Slice(pubKeys, func(i int, j int) bool { + return bytes.Compare(pubKeys[i][:], pubKeys[j][:]) < 0 + }) res, err := inst.Exec("rtm_ext_crypto_sr25519_public_keys_version_1", idData) require.NoError(t, err) @@ -1096,7 +1098,10 @@ func Test_ext_crypto_sr25519_public_keys_version_1(t *testing.T) { err = scale.Unmarshal(out, &ret) require.NoError(t, err) - sort.Slice(ret, func(i int, j int) bool { return ret[i][0] < ret[j][0] }) + sort.Slice(ret, func(i int, j int) bool { + return bytes.Compare(ret[i][:], ret[j][:]) < 0 + }) + require.Equal(t, pubKeys, ret) }