Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringHashTable is really ObjectHashTable #2

Open
CarstVaartjes opened this issue Oct 9, 2014 · 0 comments
Open

StringHashTable is really ObjectHashTable #2

CarstVaartjes opened this issue Oct 9, 2014 · 0 comments
Assignees

Comments

@CarstVaartjes
Copy link
Owner

Hi,

pandas see strings as general objects, so it can be unicode or a BSON ObjectId or a list or something else. when it puts them in the hashtable, it gets the cstring name of the object (the name representation)
we should name this ObjectHashTable (a break with Pandas naming, I know, but really more to the point) and also have a real StringHashTable (we should check with bcolz how they define a string array)
Once that is finished we should look at accepting carrays, but that probably takes putting this code directly into bcolz carray_ext (as there is no pxd for carray_ext cimports)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants