Allow service_discovery to continue without random_device #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kheaactua
force-pushed
the
missing_random_device
branch
7 times, most recently
from
066853d
to
63bb72b
Compare
fcmonteiro
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Hi @kheaactua ,
We agree with the try-catch method, but we would suggest in the fallback to use std::chrono::time_point::time_since_epoch() instead, to seed the Mersenne Twister.
That way will still ensure a decent level of randomness.
Otherwise, the PR seems ok to be merged.
There was a problem hiding this comment.
Sounds good, I'll give it a try and re-push.
There was a problem hiding this comment.
Hi @kheaactua, did you had the opportunity to change the implementation to what @fcmonteiro suggested?
Thanks in advance!
There was a problem hiding this comment.
Started, but got distracted :( , will get back to it ASAP
There was a problem hiding this comment.
My apologies for it taking so long. I just pushed a version with the Mersenne Twister. I tested this on QNX with and without random
kheaactua
force-pushed
the
missing_random_device
branch
from
63bb72b
to
d80cf31
Compare
Allow service_discovery to continue even if the random_device isn't yet available. This is unlikely to occur on linux systems, but not impossible. It is more likely on other systems such as QNX. In the event that the random device isn't available, an error message is produced and the middle of the min/max for the delay is used. Without this change, if the random device is missing, the following error is thrown: terminate called after throwing an instance of 'std::__1::system_error' what(): random_device failed to open /dev/urandom: No such file or directory Abort (core dumped)
…d. This removes the private error warning turned error by -Werror: error: private field 'check_routing_credentials_' is not used [-Werror,-Wunused-private-field] error
kheaactua
force-pushed
the
missing_random_device
branch
from
d80cf31
to
1377228
Compare
fcmonteiro
approved these changes
Nov 6, 2023
goncaloalmeida
approved these changes
Nov 6, 2023
DiogoPedrozza
added a commit
that referenced
this pull request
Nov 29, 2023
Notes: - Fix QNX build - Fix missing Stop Offer - Apply extra fixes to QNX environment - Remove key <service, instance> from the offer_commands_ - #478: deleted unused param _use_exclusive_proxy - Fix code smell related to condition variable - #462: Fix IPv6 Service Discovery - Added multicast_mutex to async function that makes use of multicast socket - #479: Allow service_discovery to continue without random_device - Fix availability handler sending false on offer - Set host/port in vsomeip_sec_client_t whenever possible - Use executor_work_guard instead of io_context::work for boost v1.66 and higher - Update Windows build - Added profile 07 as an option for E2E protection - ASIO: use heap-allocation to avoid using garbage data - Fix integer underflow in server_endpoint_impl.cpp - Cleanup prepare_stop_handlers_ - Automatic unsubscribe - Debounce now works without routingmanagerd running - Debouncing: Send last received value after debounce time + X - Fix resource deadlock avoided crash - Use closure instead of callable struct
Merged
DiogoPedrozza
added a commit
that referenced
this pull request
Nov 29, 2023
Notes: - Fix QNX build - Fix missing Stop Offer - Apply extra fixes to QNX environment - Remove key <service, instance> from the offer_commands_ - #478: deleted unused param _use_exclusive_proxy - Fix code smell related to condition variable - #462: Fix IPv6 Service Discovery - Added multicast_mutex to async function that makes use of multicast socket - #479: Allow service_discovery to continue without random_device - Fix availability handler sending false on offer - Set host/port in vsomeip_sec_client_t whenever possible - Use executor_work_guard instead of io_context::work for boost v1.66 and higher - Update Windows build - Added profile 07 as an option for E2E protection - ASIO: use heap-allocation to avoid using garbage data - Fix integer underflow in server_endpoint_impl.cpp - Cleanup prepare_stop_handlers_ - Automatic unsubscribe - Debounce now works without routingmanagerd running - Debouncing: Send last received value after debounce time + X - Fix resource deadlock avoided crash - Use closure instead of callable struct
DiogoPedrozza
added a commit
that referenced
this pull request
Nov 29, 2023
Notes: - Fix QNX build - Fix missing Stop Offer - Apply extra fixes to QNX environment - Remove key <service, instance> from the offer_commands_ - #478: deleted unused param _use_exclusive_proxy - Fix code smell related to condition variable - #462: Fix IPv6 Service Discovery - Added multicast_mutex to async function that makes use of multicast socket - #479: Allow service_discovery to continue without random_device - Fix availability handler sending false on offer - Set host/port in vsomeip_sec_client_t whenever possible - Use executor_work_guard instead of io_context::work for boost v1.66 and higher - Update Windows build - Added profile 07 as an option for E2E protection - ASIO: use heap-allocation to avoid using garbage data - Fix integer underflow in server_endpoint_impl.cpp - Cleanup prepare_stop_handlers_ - Automatic unsubscribe - Debounce now works without routingmanagerd running - Debouncing: Send last received value after debounce time + X - Fix resource deadlock avoided crash - Use closure instead of callable struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow service discovery to continue even if the
random_deviceisn't yet available. This is unlikely to occur on linux systems, but not impossible. It is more likely on other systems (e.g QNX.) In the event that therandom_deviceisn't available, an error message is produced and the middle of the min/max for the delay is used.This PR also removes the
check_routing_credentials_member on thepolicy_manager_implclass when security is disabled. This removes the private error warning turned error by -Werror: