Fix IPv6 Service Discovery #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This really fixes a bug! Please merge! |
|
@nachtfuchs yes we will merge this change :) we will first release a new version, and after that, we can merge the missing PRs. |
goncaloalmeida
approved these changes
Oct 23, 2023
DiogoPedrozza
approved these changes
Oct 23, 2023
DiogoPedrozza
added a commit
that referenced
this pull request
Nov 29, 2023
Notes: - Fix QNX build - Fix missing Stop Offer - Apply extra fixes to QNX environment - Remove key <service, instance> from the offer_commands_ - #478: deleted unused param _use_exclusive_proxy - Fix code smell related to condition variable - #462: Fix IPv6 Service Discovery - Added multicast_mutex to async function that makes use of multicast socket - #479: Allow service_discovery to continue without random_device - Fix availability handler sending false on offer - Set host/port in vsomeip_sec_client_t whenever possible - Use executor_work_guard instead of io_context::work for boost v1.66 and higher - Update Windows build - Added profile 07 as an option for E2E protection - ASIO: use heap-allocation to avoid using garbage data - Fix integer underflow in server_endpoint_impl.cpp - Cleanup prepare_stop_handlers_ - Automatic unsubscribe - Debounce now works without routingmanagerd running - Debouncing: Send last received value after debounce time + X - Fix resource deadlock avoided crash - Use closure instead of callable struct
Merged
DiogoPedrozza
added a commit
that referenced
this pull request
Nov 29, 2023
Notes: - Fix QNX build - Fix missing Stop Offer - Apply extra fixes to QNX environment - Remove key <service, instance> from the offer_commands_ - #478: deleted unused param _use_exclusive_proxy - Fix code smell related to condition variable - #462: Fix IPv6 Service Discovery - Added multicast_mutex to async function that makes use of multicast socket - #479: Allow service_discovery to continue without random_device - Fix availability handler sending false on offer - Set host/port in vsomeip_sec_client_t whenever possible - Use executor_work_guard instead of io_context::work for boost v1.66 and higher - Update Windows build - Added profile 07 as an option for E2E protection - ASIO: use heap-allocation to avoid using garbage data - Fix integer underflow in server_endpoint_impl.cpp - Cleanup prepare_stop_handlers_ - Automatic unsubscribe - Debounce now works without routingmanagerd running - Debouncing: Send last received value after debounce time + X - Fix resource deadlock avoided crash - Use closure instead of callable struct
DiogoPedrozza
added a commit
that referenced
this pull request
Nov 29, 2023
Notes: - Fix QNX build - Fix missing Stop Offer - Apply extra fixes to QNX environment - Remove key <service, instance> from the offer_commands_ - #478: deleted unused param _use_exclusive_proxy - Fix code smell related to condition variable - #462: Fix IPv6 Service Discovery - Added multicast_mutex to async function that makes use of multicast socket - #479: Allow service_discovery to continue without random_device - Fix availability handler sending false on offer - Set host/port in vsomeip_sec_client_t whenever possible - Use executor_work_guard instead of io_context::work for boost v1.66 and higher - Update Windows build - Added profile 07 as an option for E2E protection - ASIO: use heap-allocation to avoid using garbage data - Fix integer underflow in server_endpoint_impl.cpp - Cleanup prepare_stop_handlers_ - Automatic unsubscribe - Debounce now works without routingmanagerd running - Debouncing: Send last received value after debounce time + X - Fix resource deadlock avoided crash - Use closure instead of callable struct
vcomito-apexai
pushed a commit
to vcomito-apexai/vsomeip
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Julius Gesang <julius.gesang@micronova.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from IPv4 addresses to IPv6 addresses, I noticed that service discovery was no longer working.
One bug was just a missing initialization of the IPv6 address while the other bug was a missing cmsg. For IPv6 on linux it seems like the correct socket option is not
IPV6_PKTINFObut ratherIPV6_RECVPKTINFOI hope this can be merged soon, if there are any problems feel free to contact me