Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Add google test by FetchContent #550

Closed
pgawro opened this issue Oct 29, 2023 · 1 comment
Closed

[FR] Add google test by FetchContent #550

pgawro opened this issue Oct 29, 2023 · 1 comment

Comments

@pgawro
Copy link
Contributor

pgawro commented Oct 29, 2023

Google test dependency can be added by using CMake's(>=3.11) FetchContent
pgawro added a commit to pgawro/vsomeip that referenced this issue Oct 29, 2023
@pgawro
Add gtest to Fetch content COVESA#550
2125278
pgawro added a commit to pgawro/vsomeip that referenced this issue Oct 29, 2023
@pgawro
Add gtest to Fetch content COVESA#550
1615584
@goncaloalmeida
Copy link
Contributor

This is not a defect, it is a suggestion/PR. Please use the discussion tab.

goncaloalmeida pushed a commit that referenced this issue Nov 10, 2023
@pgawro
Add gtest to Fetch content #550 (#551)
70d59ed
goncaloalmeida pushed a commit to goncaloalmeida/vsomeip that referenced this issue Dec 11, 2023
Revert "Add gtest to Fetch content COVESA#550 (COVESA#551)"
f2fe3af 
Notes:
This reverts commit 70d59ed - breaking the windows builds
goncaloalmeida added a commit that referenced this issue Dec 11, 2023
@goncaloalmeida
Fixed Windows CI builds (#586)
64f8d4e 
* Revert "Add gtest to Fetch content #550 (#551)"

This reverts commit 70d59ed - breaking the windows builds

* Fix CI for Windows builds

---------

Co-authored-by: Gonçalo Almeida <Goncalo.Almeida@ctw.bmwgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgawro @goncaloalmeida