Simplify interactions with githubRelease extension properties #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interacting with CharSequence can result in some syntactical overhead compared to interacting with Strings. As an example, when using the tagName from the githubRelease extension, passing that value to another API requires converting that value to a String. This tends to add some amount of noise to the code as most APIs use Strings for such things.
tylerbertrand
force-pushed
the
tylerbertrand/use-string-over-charsequence
branch
from
32e359e
to
96b7cfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR would make the change to use Strings over CharSequence for githubRelease extension properties.
Interacting with CharSequence githubRelease extension properties can result in some syntactical overhead. As an example, when using the tagName from the githubRelease extension, passing that value to another API requires converting that value to a String. This applies to both Groovy and Kotlin.
Groovy:
Kotlin:
tagName.set(githubRelease.tagName.map { it.toString() })This tends to add some amount of noise to the code as most APIs use Strings for such things. With this PR, the above code snippets would be simplified to the following:
Groovy:
Kotlin:
Gradle build scan: https://scans.gradle.com/s/butpox5cvgpqo