-
Notifications
You must be signed in to change notification settings - Fork 145
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: corrected double opens on iOS background
- Loading branch information
Showing
1 changed file
with
6 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0868dde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there's an issue with this commit when returning from background which prevents the branch from being reinitialized and as such deepLinks which refer to an app which is in background cannot be followed within ios.
0868dde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deep link data will only pass into the app if we can confirm a fingerprint match. This match is between the link click (browser information) and app open (device information). If we cannot confidently determine a match, deep link data will not pass through.
In your tests, is deep link data never passing through whenever the app is backgrounded? Additionally, how are you testing? The steps and device information you use will be helpful for us to debug on our end.
Thanks,
0868dde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original point was mainly that e.g. this code:
Cannot work, since the
resume
event can never result with the data being handled unless I've miss understood something from the code. TherunOnce
variable prevents theinitSession
from ever running again until the scope is reninitialized (i.e. the app is closed and reopened)