-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache Manager - separate concern #5
Comments
About your points
|
@renefloor I think my point was nothing to do with header but more to the point that CacheManager sounds like pretty useful package. any data/documents can be cached.
|
Yes I understand, I also think it is very useful as a separate package. Using a count is a good idea. I will probably do that in combination with a maximum age. I will make them both configurable by the user, but I think a default of 2000 items is a bit much. |
I just made the needed changes in separate feature branch. Would like to hear your opinion. |
@renefloor looks good, but can be even better. |
@FastNinja I just moved the cache manager to its own repo and released a first version of it. Let's move the discussion there. I already refactored some bit and opened an issue for error reporting. I don't have much time coming period, so if you have any breaking issues, please make a pull request for it. |
Two thoughts crossed my mind:
These leads me to think that your
Cache Manager
actually will be helpful as a separate package.Caching data on a mobile phone is very common practice/concern so I can see it is much more widely used as
CachedNetworkImageProvider
Proposal: extract Cache Manager as a separate package. Add ability to eliminate entities. Make it generic so it is not coupled with
HttpHeaders
or any other concerns.The text was updated successfully, but these errors were encountered: