Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manifest.json #2632

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix: manifest.json #2632

merged 2 commits into from
Sep 3, 2024

Conversation

aybarsayan
Copy link
Contributor

Checklist:

Changed the manifest version to v3

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@aybarsayan aybarsayan marked this pull request as draft August 23, 2024 12:41
@aybarsayan aybarsayan marked this pull request as ready for review August 23, 2024 12:41
Dudleyneedham
Dudleyneedham reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about what these things do

src/static/manifest.json Show resolved Hide resolved
@arty-name
Copy link
Contributor

There was another branch for this purpose since a long time, I believe a few more changes are necessary

arty-name
arty-name reviewed Aug 26, 2024
View reviewed changes
src/static/manifest.json Outdated Show resolved Hide resolved
Dudleyneedham
Dudleyneedham approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggera ggera merged commit bd79f2a into BTE-Trusted-Entity:main Sep 3, 2024
1 check passed
kilted-andres added a commit that referenced this pull request Sep 11, 2024
@kilted-andres
Revert "fix: manifest.json (#2632)"
91b67b0 
This reverts commit bd79f2a.
kilted-andres added a commit that referenced this pull request Sep 11, 2024
@kilted-andres
Revert "fix: manifest.json (#2632)"
cce1ad6 
This reverts commit bd79f2a.
kilted-andres added a commit that referenced this pull request Sep 11, 2024
@kilted-andres
fix: downgrade manifest.js back to v2 (#2655)
37891fc 
* Revert "fix: manifest.json (#2632)"

This reverts commit bd79f2a.

* chore: set sporran to v2024.9.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arty-name arty-name arty-name approved these changes

@Dudleyneedham Dudleyneedham Dudleyneedham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aybarsayan @arty-name @Dudleyneedham @ggera