From e9344fc122a8eda551c1198edf36a935663892db Mon Sep 17 00:00:00 2001 From: Alicia Sykes Date: Fri, 5 Nov 2021 17:54:43 +0000 Subject: [PATCH 01/15] :bug: Fixes overlapping edit menu (#311) --- src/views/Home.vue | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/views/Home.vue b/src/views/Home.vue index bba5b52ba..85a8b9da4 100644 --- a/src/views/Home.vue +++ b/src/views/Home.vue @@ -23,6 +23,7 @@ :class="`item-group-container ` + `orientation-${layout} ` + `item-size-${itemSizeBound} ` + + (isEditMode ? 'edit-mode ' : '') + (singleSectionView ? 'single-section-view ' : '') + (this.colCount ? `col-count-${this.colCount} ` : '')" > @@ -350,6 +351,11 @@ export default { /* Hide when search term returns nothing */ .no-results { display: none; } + /* Additional spacing when in edit mode */ + &.edit-mode { + margin-bottom: 12rem; + } + /* When in single-section view mode */ &.single-section-view { display: block; From 2acf3965d2eba3857280158cdfc384e71013cd15 Mon Sep 17 00:00:00 2001 From: Alicia Sykes Date: Fri, 5 Nov 2021 18:19:37 +0000 Subject: [PATCH 02/15] :bug: Fixes status check dot in edit mode (#301) --- src/components/LinkItems/Item.vue | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/src/components/LinkItems/Item.vue b/src/components/LinkItems/Item.vue index e9a18a099..06a6ac9f6 100644 --- a/src/components/LinkItems/Item.vue +++ b/src/components/LinkItems/Item.vue @@ -5,7 +5,7 @@ @contextmenu.prevent :href="hyperLinkHref" :target="anchorTarget" - :class="`item ${!icon? 'short': ''} size-${itemSize} ${isAddNew ? 'add-new' : ''}`" + :class="`item ${makeClassList}`" v-tooltip="getTooltipOptions()" rel="noopener noreferrer" tabindex="0" :id="`link-${id}`" @@ -30,8 +30,10 @@ :statusSuccess="statusResponse ? statusResponse.successStatus : undefined" :statusText="statusResponse ? statusResponse.message : undefined" /> + + + From 65f6882e0db0d9b446b600deb599148f55b2256a Mon Sep 17 00:00:00 2001 From: Alicia Sykes Date: Fri, 5 Nov 2021 18:27:55 +0000 Subject: [PATCH 03/15] :bug: Fixes item text flicker on hover (#312) --- src/components/LinkItems/Item.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/LinkItems/Item.vue b/src/components/LinkItems/Item.vue index 06a6ac9f6..e66712df5 100644 --- a/src/components/LinkItems/Item.vue +++ b/src/components/LinkItems/Item.vue @@ -364,10 +364,10 @@ export default { box-shadow: var(--item-hover-shadow); background: var(--item-background-hover); color: var(--item-text-color-hover); - position: relative; - .tile-title span.text { - white-space: pre-wrap; - } + // position: relative; + // .tile-title span.text { + // white-space: pre-wrap; + // } } &:focus { outline: 2px solid var(--primary); From 8bff8335f036bcb0c07264ef4dbca17a3dab1b13 Mon Sep 17 00:00:00 2001 From: Alicia Sykes Date: Fri, 5 Nov 2021 18:35:03 +0000 Subject: [PATCH 04/15] :bug: Fix unequal button height in French (#311) --- src/components/InteractiveEditor/EditModeSaveMenu.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/InteractiveEditor/EditModeSaveMenu.vue b/src/components/InteractiveEditor/EditModeSaveMenu.vue index 2d1b4c954..6050656c7 100644 --- a/src/components/InteractiveEditor/EditModeSaveMenu.vue +++ b/src/components/InteractiveEditor/EditModeSaveMenu.vue @@ -211,7 +211,7 @@ div.edit-mode-bottom-banner { /* Main sections */ .edit-banner-section { padding: 0.5rem; - height: 100%; + height: 90%; /* Section sub-titles */ p.section-sub-title { margin: 0; @@ -234,7 +234,7 @@ div.edit-mode-bottom-banner { grid-template-columns: repeat(2, 1fr); button { margin: 0.25rem; - height: fit-content; + height: stretch; } p.section-sub-title { grid-column-start: span 2; From 5f9d1656256dde4cd1bad2fe388795ff0b093ffa Mon Sep 17 00:00:00 2001 From: Alicia Sykes Date: Fri, 5 Nov 2021 18:50:51 +0000 Subject: [PATCH 05/15] :memo: Fixes broken links in docs (#310) --- .github/.lycheeexclude | 14 ++++++++++++++ .github/workflows/docs-link-checker.yml | 7 ++++++- docs/status-indicators.md | 2 +- 3 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 .github/.lycheeexclude diff --git a/.github/.lycheeexclude b/.github/.lycheeexclude new file mode 100644 index 000000000..58461b091 --- /dev/null +++ b/.github/.lycheeexclude @@ -0,0 +1,14 @@ +# Ignore list, for automated broken link checking + +https://fonts.gstatic.com/** +https://metager.org/meta/** +https://developers.cloudflare.com/** + +http://localhost** +https://localhost** +http://192.168** +https://192.168** +file:///github/** +http://[dashy-location]** +https://[dashy-location]** +**.local/** \ No newline at end of file diff --git a/.github/workflows/docs-link-checker.yml b/.github/workflows/docs-link-checker.yml index 527b5af91..c344774cc 100644 --- a/.github/workflows/docs-link-checker.yml +++ b/.github/workflows/docs-link-checker.yml @@ -11,10 +11,15 @@ jobs: steps: - uses: actions/checkout@v2 + - name: Load Excludes + run: | + LYCHEE_EXCLUDE=$(sed -e :a -e 'N;s/\n/ /;ta' .github/.lycheeexclude) + echo "LYCHEE_EXCLUDE=$LYCHEE_EXCLUDE" >> $GITHUB_ENV + - name: Check for Broken Links uses: lycheeverse/lychee-action@v1.0.8 with: - args: --verbose -a 200,302,304,429 --no-progress **/*.md **/*.html + args: --verbose -a 200,302,304,429 --exclude ${{ env.LYCHEE_EXCLUDE }} --exclude-mail --no-progress **/*.md env: GITHUB_TOKEN: ${{secrets.BOT_GITHUB_TOKEN}} LYCHEE_OUT: .github/broken-link-report.md diff --git a/docs/status-indicators.md b/docs/status-indicators.md index 7bc866ae5..0c473e8ee 100644 --- a/docs/status-indicators.md +++ b/docs/status-indicators.md @@ -65,7 +65,7 @@ If the status is always returning an error, despite the service being online, th If your service requires requests to include any authorization in the headers, then use the `statusCheckHeaders` property, as described above. If you are still having issues, it may be because your target application is blocking requests from Dashy's IP. This is a [CORS error](https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS), and can be fixed by setting the headers on your target app, to include: ``` -Access-Control-Allow-Origin: https://location-of-dashy/ +Access-Control-Allow-Origin: https://[dashy-location]/ Vary: Origin ``` If the URL you are checking is not using HTTPS, then you may need to disable the rejection of insecure requests. This can be done by setting `statusCheckAllowInsecure` to true for a given item. From 453a3c107c2ffeddc3c7f8d6e69704ff6b34faf3 Mon Sep 17 00:00:00 2001 From: Alicia Sykes Date: Fri, 5 Nov 2021 18:55:25 +0000 Subject: [PATCH 06/15] :zap: Refactors class names in collapsible --- src/components/LinkItems/Collapsable.vue | 49 +++++++++++++++--------- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/src/components/LinkItems/Collapsable.vue b/src/components/LinkItems/Collapsable.vue index c2d970845..76732f03e 100644 --- a/src/components/LinkItems/Collapsable.vue +++ b/src/components/LinkItems/Collapsable.vue @@ -1,13 +1,13 @@