From 1670cc63aa2964c886e181fbf2ca7155d43ae0f5 Mon Sep 17 00:00:00 2001 From: Yuchao Yan Date: Thu, 12 Sep 2024 16:47:49 +0800 Subject: [PATCH] Fix "line-too-long" for property of model (#2837) * fix line-too-long for property of model * changelog --- .chronus/changes/fix-pylint-2024-09-12-2024-8-12-16-9-4.md | 7 +++++++ .../pygen/codegen/serializers/model_serializer.py | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .chronus/changes/fix-pylint-2024-09-12-2024-8-12-16-9-4.md diff --git a/.chronus/changes/fix-pylint-2024-09-12-2024-8-12-16-9-4.md b/.chronus/changes/fix-pylint-2024-09-12-2024-8-12-16-9-4.md new file mode 100644 index 0000000000..fbb3f12e82 --- /dev/null +++ b/.chronus/changes/fix-pylint-2024-09-12-2024-8-12-16-9-4.md @@ -0,0 +1,7 @@ +--- +changeKind: fix +packages: + - "@azure-tools/typespec-python" +--- + +Fix "line-too-long" for property of model \ No newline at end of file diff --git a/packages/typespec-python/generator/pygen/codegen/serializers/model_serializer.py b/packages/typespec-python/generator/pygen/codegen/serializers/model_serializer.py index 196ba59384..651b19eb64 100644 --- a/packages/typespec-python/generator/pygen/codegen/serializers/model_serializer.py +++ b/packages/typespec-python/generator/pygen/codegen/serializers/model_serializer.py @@ -261,9 +261,10 @@ def declare_property(prop: Property) -> str: else "" ) generated_code = f'{prop.client_name}: {prop.type_annotation()} = {field}({", ".join(args)})' + # there is 4 spaces indentation so original line length limit 120 - 4 = 116 pylint_disable = ( " # pylint: disable=line-too-long" - if len(generated_code) <= 120 < (len(generated_code) + len(type_ignore)) + if len(generated_code) <= 116 < (len(generated_code) + len(type_ignore)) else "" ) return f"{generated_code}{type_ignore}{pylint_disable}"