{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":704719381,"defaultBranch":"main","name":"react","ownerLogin":"AsanAzimkulov","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-10-13T22:46:51.000Z","ownerAvatar":"https://github.com/avatars/u/99381933?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1697378470.0","currentOid":""},"activityList":{"items":[{"before":"e3748a0bde80dd1f097fd8000702aba9fca454ef","after":"9617d39eca1fbac58afe73a23580d781ea20211d","ref":"refs/heads/main","pushedAt":"2023-10-19T02:44:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"[Fizz] Add proper assertion for stream fix (#27543)\n\nIn https://github.com/facebook/react/pull/27541 I added tests to assert\r\nthat the write after close bug was fixed. However the Node\r\nimplementation has an abort behavior preventing reproduction of the\r\noriginal issue and the Browser build does not use AsyncLocalStorage\r\nwhich also prevents reproduction. This change moves the Browser test to\r\na Edge runtime where AsyncLocalStorage is polyfilled. In this\r\nimplementation the test does correctly fail when the patch is removed.","shortMessageHtmlLink":"[Fizz] Add proper assertion for stream fix (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1950383153\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/27543\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/27543/hovercard\" href=\"https://github.com/facebook/react/pull/27543\">facebook#27543</a>)"}},{"before":"67cc9ba8789335b9da0838a446137c1be62adbcd","after":"e3748a0bde80dd1f097fd8000702aba9fca454ef","ref":"refs/heads/main","pushedAt":"2023-10-18T09:58:53.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"[Fizz] Pass cancellation reason to abort (#27536)\n\nThis was implemented correctly for Flight but not Fizz. Hard to keep\r\nthese many wrappers in sync.","shortMessageHtmlLink":"[Fizz] Pass cancellation reason to abort (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1948587599\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/27536\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/27536/hovercard\" href=\"https://github.com/facebook/react/pull/27536\">facebook#27536</a>)"}},{"before":"09fbee89d62bc1c4a00e64474346cb9bc87682cb","after":"67cc9ba8789335b9da0838a446137c1be62adbcd","ref":"refs/heads/main","pushedAt":"2023-10-17T02:57:00.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"Fix: error messages (#27523)\n\n<!--\r\n  Thanks for submitting a pull request!\r\nWe appreciate you spending the time to work on these changes. Please\r\nprovide enough information so that others can review your pull request.\r\nThe three fields below are mandatory.\r\n\r\nBefore submitting a pull request, please make sure the following is\r\ndone:\r\n\r\n1. Fork [the repository](https://github.com/facebook/react) and create\r\nyour branch from `main`.\r\n  2. Run `yarn` in the repository root.\r\n3. If you've fixed a bug or added code that should be tested, add tests!\r\n4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch\r\nTestName` is helpful in development.\r\n5. Run `yarn test --prod` to test in the production environment. It\r\nsupports the same options as `yarn test`.\r\n6. If you need a debugger, run `yarn test --debug --watch TestName`,\r\nopen `chrome://inspect`, and press \"Inspect\".\r\n7. Format your code with\r\n[prettier](https://github.com/prettier/prettier) (`yarn prettier`).\r\n8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only\r\ncheck changed files.\r\n  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).\r\n  10. If you haven't already, complete the CLA.\r\n\r\nLearn more about contributing:\r\nhttps://reactjs.org/docs/how-to-contribute.html\r\n-->\r\n\r\n## Summary\r\nChanges `before before` to `before` in error messages.\r\n\r\n<!--\r\nExplain the **motivation** for making this change. What existing problem\r\ndoes the pull request solve?\r\n-->\r\nI want to improve error logs\r\n\r\n## How did you test this change?\r\n\r\n<!--\r\nDemonstrate the code is solid. Example: The exact commands you ran and\r\ntheir output, screenshots / videos if the pull request changes the user\r\ninterface.\r\nHow exactly did you verify that your PR solves the issue you wanted to\r\nsolve?\r\n  If you leave this empty, your PR will very likely be closed.\r\n-->","shortMessageHtmlLink":"Fix: error messages (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1943902177\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/27523\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/27523/hovercard\" href=\"https://github.com/facebook/react/pull/27523\">facebook#27523</a>)"}},{"before":"09fbee89d62bc1c4a00e64474346cb9bc87682cb","after":"9c405850e1a5a424296775b13de970041a2ab2ce","ref":"refs/heads/fix-error-messages","pushedAt":"2023-10-15T14:03:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"Fix: error messages\n\nChanges `before before` to `before` in error messages.","shortMessageHtmlLink":"Fix: error messages"}},{"before":null,"after":"09fbee89d62bc1c4a00e64474346cb9bc87682cb","ref":"refs/heads/fix-error-messages","pushedAt":"2023-10-15T14:01:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"[Fizz] Don't pop the replay stack if we've already rendered past an element (#27513)\n\nThis is the same problem as we had with keyPath before where if the\r\nelement itself suspends, we have to restore the replay node to what it\r\nwas before, however, if something below the element suspends we\r\nshouldn't pop it because that will pop it back up the stack.\r\n\r\nInstead of passing replay as an argument to every renderElement\r\nfunction, I use a hack to compare if the node is still the same as the\r\none we tried to render, then that means we haven't stepped down into the\r\nchild yet. Maybe this is not quite correct because in theory you could\r\nhave a recursive node that just renders itself over and over until some\r\ncontext bails out.\r\n\r\nThis solves an issue where if you suspended in an element it would retry\r\ntrying to replay from that element but using the postponed state from\r\nthe root.","shortMessageHtmlLink":"[Fizz] Don't pop the replay stack if we've already rendered past an e…"}},{"before":"a3b929676d989efecac591054d13116f33a5bd3c","after":"09fbee89d62bc1c4a00e64474346cb9bc87682cb","ref":"refs/heads/main","pushedAt":"2023-10-15T14:00:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"[Fizz] Don't pop the replay stack if we've already rendered past an element (#27513)\n\nThis is the same problem as we had with keyPath before where if the\r\nelement itself suspends, we have to restore the replay node to what it\r\nwas before, however, if something below the element suspends we\r\nshouldn't pop it because that will pop it back up the stack.\r\n\r\nInstead of passing replay as an argument to every renderElement\r\nfunction, I use a hack to compare if the node is still the same as the\r\none we tried to render, then that means we haven't stepped down into the\r\nchild yet. Maybe this is not quite correct because in theory you could\r\nhave a recursive node that just renders itself over and over until some\r\ncontext bails out.\r\n\r\nThis solves an issue where if you suspended in an element it would retry\r\ntrying to replay from that element but using the postponed state from\r\nthe root.","shortMessageHtmlLink":"[Fizz] Don't pop the replay stack if we've already rendered past an e…"}},{"before":"bd357027b6e40a734002c665e9258ae16e6dedd0","after":"a3b929676d989efecac591054d13116f33a5bd3c","ref":"refs/heads/main","pushedAt":"2023-10-15T13:56:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"Revert \"Fix: error messages\"\n\nThis reverts commit bd357027b6e40a734002c665e9258ae16e6dedd0.","shortMessageHtmlLink":"Revert \"Fix: error messages\""}},{"before":"09fbee89d62bc1c4a00e64474346cb9bc87682cb","after":"bd357027b6e40a734002c665e9258ae16e6dedd0","ref":"refs/heads/main","pushedAt":"2023-10-15T13:46:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"AsanAzimkulov","name":"Asan Azimkulov","path":"/AsanAzimkulov","primaryAvatarUrl":"https://github.com/avatars/u/99381933?s=80&v=4"},"commit":{"message":"Fix: error messages\n\nFixes `before before` to 'before' in error messages","shortMessageHtmlLink":"Fix: error messages"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMC0xOVQwMjo0NDo1OS4wMDAwMDBazwAAAAOaihHw","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMC0xOVQwMjo0NDo1OS4wMDAwMDBazwAAAAOaihHw","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMC0xNVQxMzo0NjoyOS4wMDAwMDBazwAAAAOXY3h-"}},"title":"Activity · AsanAzimkulov/react"}