Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Required properties deleted from Data Types still referenced in downloaded YAML #483

Closed
mmindenhall opened this issue Oct 29, 2018 · 2 comments

Comments

@mmindenhall
Copy link

mmindenhall commented Oct 29, 2018

I have been using the tool to design a new API (love it so far!).

I had the need to change my property names from snake_case to camelCase to be consistent with another project. Since renaming is "Not yet implemented", I created a new property (e.g., fileType), then copied the description, whether Required, and Type from the existing file_type property. I then deleted the file_type property.

However, file_type when I download the YAML, the deleted property name is still present (along with the new property name):

    DataSource:
      required:
      - file_type
      - fileType
      - tenantId

The old name is only referenced within the required list (it was correctly removed from the properties list).

@EricWittmann
Copy link
Member

Thanks for the bug report, @mmindenhall - glad you like Apicurio so far! I actually just discovered this bug myself last week. I'm going to leave this issue open, but you may want to also follow the following issue for progress updates (if interested):

https://github.com/Apicurio/oai-ts-commands/issues/1

@EricWittmann EricWittmann changed the title Required properties deleted from Data Types still referenced in downloaded YAML Editor: Required properties deleted from Data Types still referenced in downloaded YAML Oct 29, 2018
@EricWittmann
Copy link
Member

The commands for deleting a single property and deleting all schema properties have both been updated to also update the list of required properties appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants