From 095ada5dd63cc28381ce1c74a3526437dcd9e91a Mon Sep 17 00:00:00 2001
From: Smita Kulkarni <Smita.Kulkarni@clickhouse.com>
Date: Wed, 8 May 2024 10:55:26 +0200
Subject: [PATCH] Support running function for parameterized view value
 assignment

---
 src/Interpreters/Context.cpp                       |  4 ++--
 src/Parsers/FunctionParameterValuesVisitor.cpp     | 14 +++++++++++---
 src/Parsers/FunctionParameterValuesVisitor.h       |  3 ++-
 .../03146_parameterized_view_with_date.reference   |  1 +
 .../03146_parameterized_view_with_date.sql         | 12 ++++++++++++
 5 files changed, 28 insertions(+), 6 deletions(-)
 create mode 100644 tests/queries/0_stateless/03146_parameterized_view_with_date.reference
 create mode 100644 tests/queries/0_stateless/03146_parameterized_view_with_date.sql

diff --git a/src/Interpreters/Context.cpp b/src/Interpreters/Context.cpp
index 5826bfc15cc1..e4275a75ff72 100644
--- a/src/Interpreters/Context.cpp
+++ b/src/Interpreters/Context.cpp
@@ -1817,7 +1817,7 @@ StoragePtr Context::executeTableFunction(const ASTPtr & table_expression, const
         if (table.get()->isView() && table->as<StorageView>() && table->as<StorageView>()->isParameterizedView())
         {
             auto query = table->getInMemoryMetadataPtr()->getSelectQuery().inner_query->clone();
-            NameToNameMap parameterized_view_values = analyzeFunctionParamValues(table_expression);
+            NameToNameMap parameterized_view_values = analyzeFunctionParamValues(table_expression, getQueryContext());
             StorageView::replaceQueryParametersIfParametrizedView(query, parameterized_view_values);
 
             ASTCreateQuery create;
@@ -2031,7 +2031,7 @@ StoragePtr Context::buildParametrizedViewStorage(const ASTPtr & table_expression
         return nullptr;
 
     auto query = original_view->getInMemoryMetadataPtr()->getSelectQuery().inner_query->clone();
-    NameToNameMap parameterized_view_values = analyzeFunctionParamValues(table_expression);
+    NameToNameMap parameterized_view_values = analyzeFunctionParamValues(table_expression, getQueryContext());
     StorageView::replaceQueryParametersIfParametrizedView(query, parameterized_view_values);
 
     ASTCreateQuery create;
diff --git a/src/Parsers/FunctionParameterValuesVisitor.cpp b/src/Parsers/FunctionParameterValuesVisitor.cpp
index 3692a4c73e55..e791e07cdfb5 100644
--- a/src/Parsers/FunctionParameterValuesVisitor.cpp
+++ b/src/Parsers/FunctionParameterValuesVisitor.cpp
@@ -7,6 +7,7 @@
 #include <Common/FieldVisitorToString.h>
 #include <Parsers/ASTHelpers.h>
 #include <Common/assert_cast.h>
+#include <Interpreters/evaluateConstantExpression.h>
 
 
 namespace DB
@@ -20,8 +21,9 @@ namespace ErrorCodes
 class FunctionParameterValuesVisitor
 {
 public:
-    explicit FunctionParameterValuesVisitor(NameToNameMap & parameter_values_)
+    explicit FunctionParameterValuesVisitor(NameToNameMap & parameter_values_, ContextPtr context_)
         : parameter_values(parameter_values_)
+         ,context(context_)
     {
     }
 
@@ -35,6 +37,7 @@ class FunctionParameterValuesVisitor
 
 private:
     NameToNameMap & parameter_values;
+    ContextPtr context;
 
     void visitFunction(const ASTFunction & parameter_function)
     {
@@ -64,15 +67,20 @@ class FunctionParameterValuesVisitor
                         parameter_values[identifier->name()] = convertFieldToString(cast_literal->value);
                     }
                 }
+                else
+                {
+                    ASTPtr res = evaluateConstantExpressionOrIdentifierAsLiteral(expression_list->children[1], context);
+                    parameter_values[identifier->name()] = convertFieldToString(res->as<ASTLiteral>()->value);
+                }
             }
         }
     }
 };
 
-NameToNameMap analyzeFunctionParamValues(const ASTPtr & ast)
+NameToNameMap analyzeFunctionParamValues(const ASTPtr & ast, ContextPtr context)
 {
     NameToNameMap parameter_values;
-    FunctionParameterValuesVisitor(parameter_values).visit(ast);
+    FunctionParameterValuesVisitor(parameter_values, context).visit(ast);
     return parameter_values;
 }
 
diff --git a/src/Parsers/FunctionParameterValuesVisitor.h b/src/Parsers/FunctionParameterValuesVisitor.h
index e6ce0e42d06b..8c2686dcc65a 100644
--- a/src/Parsers/FunctionParameterValuesVisitor.h
+++ b/src/Parsers/FunctionParameterValuesVisitor.h
@@ -2,12 +2,13 @@
 
 #include <Core/Names.h>
 #include <Parsers/IAST_fwd.h>
+#include <Interpreters/Context_fwd.h>
 
 
 namespace DB
 {
 
 /// Find parameters in a query parameter values and collect them into map.
-NameToNameMap analyzeFunctionParamValues(const ASTPtr & ast);
+NameToNameMap analyzeFunctionParamValues(const ASTPtr & ast, ContextPtr context);
 
 }
diff --git a/tests/queries/0_stateless/03146_parameterized_view_with_date.reference b/tests/queries/0_stateless/03146_parameterized_view_with_date.reference
new file mode 100644
index 000000000000..1d6227dbbcba
--- /dev/null
+++ b/tests/queries/0_stateless/03146_parameterized_view_with_date.reference
@@ -0,0 +1 @@
+2	2024-04-01 01:00:00
diff --git a/tests/queries/0_stateless/03146_parameterized_view_with_date.sql b/tests/queries/0_stateless/03146_parameterized_view_with_date.sql
new file mode 100644
index 000000000000..53022e969ab9
--- /dev/null
+++ b/tests/queries/0_stateless/03146_parameterized_view_with_date.sql
@@ -0,0 +1,12 @@
+
+drop table if exists table_pv;
+create table table_pv (id Int32, timestamp_field DateTime) engine = Memory();
+
+insert into table_pv values(1, '2024-03-01 00:00:00');
+insert into table_pv values (2, '2024-04-01 01:00:00');
+
+create view pv as select * from table_pv where timestamp_field > {timestamp_param:DateTime};
+
+select * from pv (timestamp_param=toDateTime('2024-04-01 00:00:01'));
+
+drop table table_pv;