Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of this project #1

Closed
feathecutie opened this issue Mar 12, 2024 · 7 comments
Closed

Future of this project #1

feathecutie opened this issue Mar 12, 2024 · 7 comments

Comments

@feathecutie
Copy link
Contributor

Hey, as you might have seen in the nixpkgs issue regarding this, I have recently forked this repo in order to implement pkgs.formats.kdl in nixpkgs. That implemention (https://github.com/feathecutie/nixpkgs/tree/formats-kdl) is basically ready to be upstreamed now, but would also requiring packaging some version of this project in nixpkgs.

Are you interested in me contributing my changes back into this repo, in order to make this repo the main codebase that gets packaged? Otherwise (if you're not interested in continuing to maintain this), I would simply upstream my fork of this repo instead.

@AgathaSorceress
Copy link
Owner

I would be happy to merge your changes and continue maintaining them :)

@feathecutie
Copy link
Contributor Author

Sure! I'll open a PR then

@feathecutie
Copy link
Contributor Author

Btw, I do already have an open PR in nixpkgs for this now, with myself added as a maintainer for this package. I would simply change the src of the package to your repo then, but if you prefer to be the nixpkgs maintainer of this, you could also upstream this package yourself (I don't think I'd be allowed to add you as a maintainer in my PR at least), and I would just indicate that my PR depends on yours.

@eclairevoyant
Copy link

I don't think I'd be allowed to add you as a maintainer in my PR at least

That's fine as long as they've confirmed agreement. And "maintainer" in nixpkgs mostly means getting pings about issues/PRs; anyone can submit a PR to update the package.

@feathecutie
Copy link
Contributor Author

In that case, it would probably make sense to just do everything in one PR.

@AgathaSorceress: If you'd like to, I could add you to the maintainers list of this package in my PR. However, you also don't seem to be in maintainers-list.nix yet, so this would require me adding you there too.
This would require you somehow sending me your preferred entry for the maintainers list, which would be doable but it might make more sense to just do this yourself in a later PR if that's something you care about, and for me to just merge my PR as is (once you've merged my changes back into this repo).

@AgathaSorceress
Copy link
Owner

I just merged your changes, can also make a release/tag if it would be useful. I think it makes the most sense for you to merge your PR and for me to just add myself as a maintainer later.

@feathecutie
Copy link
Contributor Author

Neat, thanks! A tag is not really necessary I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants