Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable Changelog Check is not fork-safe #156

Closed
jhkennedy opened this issue Jun 12, 2024 · 0 comments · Fixed by #162
Closed

Reusable Changelog Check is not fork-safe #156

jhkennedy opened this issue Jun 12, 2024 · 0 comments · Fixed by #162
Labels
bug Something isn't working Jira Bug Create a Jira Bug for this issue

Comments

@jhkennedy
Copy link
Contributor

jhkennedy commented Jun 12, 2024

Jira: https://asfdaac.atlassian.net/browse/TOOL-2863

Note: The above link is accessible only to members of ASF.


The Reusable Changelog Check action uses Zomzog/changelog-checker under the hood with the default checkNotification: Detailed:

The checkNotification allows switching between Simple and Detailed checks. The simple check is based on the default check of the action. The detailed check will create a second check with a more precise message, but it required write access so it does not work with forks.

Detailed check fallback to simple for forks.

Even though it says it falls back to the simple check for forks, it still tries to create a secondary check and fails with HTTP 403. We see this most often with dependabot PRs (effectively fork PRs), which shouldn't run the detailed check as they are labeled bumpless but still fail with HTTP 403 errors when trying to create the secondary check:

It does seem to still work for non-forks, e.g.:

However, Zomzog/changelog-checker is a Node.js 12 action, which is being forced to run on Node.js 16, which is also deprecated and should be running on Node.js 20 now. The last release was in Sept. 2022, and it hasn't seen a commit on the default branch since Jul. 2023, so we should find an alternative for this action.

tarides/changelog-check-action looks like a potential alternative, but it doesn't allow you to customize the no changelog label, so we'd need to contribute that upstream. Notably, tarides/changelog-check-action is just a really simple shell script:
https://github.com/tarides/changelog-check-action/blob/main/check.sh
so we could also implement something similar ourselves.

@jhkennedy jhkennedy added the bug Something isn't working label Jun 12, 2024
@jtherrmann jtherrmann added the Jira Bug Create a Jira Bug for this issue label Jun 12, 2024
@jtherrmann jtherrmann linked a pull request Jun 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Jira Bug Create a Jira Bug for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants