Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github security changes for git:// breaks SuperBuild #1323

Closed
liamtimms opened this issue Mar 16, 2022 · 3 comments · Fixed by #1324
Closed

Github security changes for git:// breaks SuperBuild #1323

liamtimms opened this issue Mar 16, 2022 · 3 comments · Fixed by #1324

Comments

@liamtimms
Copy link

This issue should be a quick fix but currently running the ANTs SuperBuild results in the following:

 -- SuperBuild - ANTS => Requires VTK, ITKv5,
-- SuperBuild -   VTK[OK]
-- SuperBuild -   ITKv5[OK]
-- SuperBuild - ANTS[OK]
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ripley/.cache/paru/clone/ants-git/src/ants-git/antsBuild
[  4%] Performing download step (git clone) for 'VTK'
Cloning into 'VTK'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

which is fairly self-explanatory. This change went into effect yesterday:

Last year, GitHub announced the deprecation of the unsecured Git protocol due to security reasons. This change will be made permanent on March 15, 2022.

https://blog.readthedocs.com/github-git-protocol-deprecation/

So the clone steps for ITKv5 and VTK are currently borked. That blog suggests simply changing to clone off https:// rather than git://, but I haven't tested it yet.

When did the error occur?

[ ] CMake configuration (cmake / ccmake)
[ X] Compilation (make)
[ ] Installation (make install)

Build environment

  • OS: Linux (Arch)
  • OS version: rolling
  • Type of system: desktop

ANTs version

git master branch

@cookpa
Copy link
Member

cookpa commented Mar 16, 2022

Thanks for letting us know. Does it work if you set ANTS_USE_GIT_PROTOCOL to OFF?

@liamtimms
Copy link
Author

Yep, @cookpa, that option appears to bypass this (as might be expected).

@cookpa
Copy link
Member

cookpa commented Mar 17, 2022

Great, time to make that the default then I think.

@cookpa cookpa linked a pull request Mar 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants